New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DOMDocument issues with AMP boilerplate and encodings #4141
Conversation
Size Change: 0 B Total Size: 1.24 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume most of the HTML class here won't be necessary once the common lib from the AMP plugin is added as a dependency?
Codecov Report
@@ Coverage Diff @@
## main #4141 +/- ##
===========================================
+ Coverage 35.45% 82.81% +47.35%
===========================================
Files 715 792 +77
Lines 12680 13948 +1268
===========================================
+ Hits 4496 11551 +7055
+ Misses 8184 2397 -5787
Flags with carried forward coverage won't be shown. Click here to find out more.
|
@westonruter Yeah we'd remove all redundant parts for sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I presume this will be very short-lived if we copy the Document
class from the AMP plugin.
Summary
See #4140 for details. This is a somewhat hacky workaround for libxml < 2.8, but it's also what the AMP plugin does:
<noscript>
part from markup<noscript>
Relevant Technical Choices
To-do
User-facing changes
N/A
Testing Instructions
Fixes #4140
Fixes #4166