Editor: Updated close icon and fixed input text overlap #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mariano-formidable
force-pushed
the
bug/1874-update-input-display
branch
from
9c56b31
to
0eff70a
Compare
|
Size Change: -49 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
| @@ -19,6 +19,7 @@ module.exports = { | |||
| './stories/**/*.js', | |||
| '../assets/src/dashboard/**/stories/*.@(js|mdx)', | |||
| '../assets/src/edit-story/**/stories/*.@(js|mdx)', | |||
| '../assets/src/animation/**/stories/*.@(js|mdx)', | |||
There was a problem hiding this comment.
Added our effect/part animations back to storybook.
| @@ -100,7 +100,7 @@ export function AnimationPart(type, args) { | |||
| [ANIMATION_EFFECTS.ZOOM.value]: EffectZoom, | |||
| [ANIMATION_EFFECTS.DROP.value]: EffectDrop, | |||
| [ANIMATION_EFFECTS.ROTATE_IN.value]: EffectRotateIn, | |||
| }[type] || throughput; | |||
| }[type?.value || type] || throughput; | |||
There was a problem hiding this comment.
Small fix so storybook effect animations get back to working.
mariano-formidable
changed the title
mariano-formidable
requested review from
barklund,
BrittanyIRL,
carloskelly13 and
dmmulroy
mariano-formidable
requested review from
spacedmonkey and
swissspidy
as code owners
Codecov Report
@@ Coverage Diff @@
## main #4167 +/- ##
==========================================
+ Coverage 80.09% 82.46% +2.37%
==========================================
Files 809 812 +3
Lines 14120 14147 +27
==========================================
+ Hits 11310 11667 +357
+ Misses 2810 2480 -330
Flags with carried forward coverage won't be shown. Click here to find out more.
|
BrittanyIRL
approved these changes
Aug 21, 2020
littlemilkstudio
approved these changes
Aug 24, 2020
swissspidy
added
Group: Style Panel
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the text input used in the Editor. It updates the clear text icon, and prevents the text from being clipped by the icon.
User-facing changes
The text input component used in the "Link" panel and the "Accessibility" panel has been updated.
Testing Instructions
1.) Open a story in the Editor.
2.) Add an image to the page.
3.) Click on the image and type in really long text into the "Link" and/or "Accessibility" panel and notice that the "clear text" icon is a nice big X, and notice that the input text does not get overlapped by the icon (it gets clipped).
Fixes #1874
Screenshot