New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added excerpt panel to document inspector #4264
Conversation
Size Change: +765 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
16b7048
to
a7e8d35
Compare
Codecov Report
@@ Coverage Diff @@
## main #4264 +/- ##
==========================================
- Coverage 83.35% 83.22% -0.14%
==========================================
Files 831 834 +3
Lines 14535 14659 +124
==========================================
+ Hits 12116 12200 +84
- Misses 2419 2459 +40
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected and looks great - just two minor comments about simplifications.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had two small nits but this looks great and works well 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Text area works as you've laid out in the editor both with cursor and keyboard. Storybook add is great, thank you for doing that! And unit tests are working locally for me.
a7e8d35
to
c68f77f
Compare
Summary
This PR adds the Excerpt Panel to the document inspector. It also adds a
TextArea
Storybook sample andExcerptPanel
tests.Relevant Technical Choices
The figma design displays a 100 character limit, but I choose to up it to 200 characters based on Pascal's suggestion (it follows how Twitter does it) in the main ticket (#490).
User-facing changes
The "Excerpt Panel" will now appear within the "Document" tab for the entire story (above the "Permalink Panel").
Testing Instructions
1.) Open up a new or existing story in the Editor.
2.) Click on "Document" in the panel to the right to revel the document inspector.
3.) Scroll down the document inspector to find the "Excerpt" panel. It should be located below "Publishing" and above "Permalink".
4.) In the Excerpt panel you should be able to do the following:
Fixes #490
Screenshots
Empty Excerpt panel:
Nicely filled Excerpt panel: