Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updating page advancement on the first load #4345

Merged
merged 24 commits into from Sep 8, 2020
Merged

Conversation

miina
Copy link
Contributor

@miina miina commented Sep 4, 2020

Summary

Relevant Technical Choices

To-do

  • Tests

User-facing changes

Testing Instructions

  1. Add a new Story
  2. Verify that "Save draft" button is not active without making any changes
  3. Switch to the Document panel
  4. Verify that "Save draft" button doesn't change to active.

Fixes #4094
Fixes #1907

@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2020

Size Change: +34 B (0%)

Total Size: 1.24 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 296 B 0 B
assets/css/stories-dashboard.css 328 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.86 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 9.91 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.78 kB 0 B
assets/js/edit-story.js 497 kB +32 B (0%)
assets/js/stories-dashboard.js 586 kB +2 B (0%)
assets/js/web-stories-activation-notice.js 63.6 kB 0 B
assets/js/web-stories-embed-block.js 16.9 kB 0 B

compressed-size-action

@miina miina marked this pull request as ready for review September 4, 2020 09:57
Copy link
Contributor

@barklund barklund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected!

@miina
Copy link
Contributor Author

miina commented Sep 7, 2020

There's an issue with Karma tests (#4364 ) which blocks merging this, however, sending to QA meanwhile already.

@csossi
Copy link

csossi commented Sep 7, 2020

Verified in QA

@miina miina removed the request for review from spacedmonkey September 7, 2020 13:56
Copy link
Contributor

@spacedmonkey spacedmonkey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 8, 2020

Codecov Report

Merging #4345 into main will increase coverage by 12.92%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #4345       +/-   ##
===========================================
+ Coverage   70.41%   83.33%   +12.92%     
===========================================
  Files         842      842               
  Lines       14908    14909        +1     
===========================================
+ Hits        10497    12424     +1927     
+ Misses       4411     2485     -1926     
Flag Coverage Δ
#karmatests 71.64% <50.00%> (+42.08%) ⬆️
#unittests 66.40% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...y/components/inspector/document/pageAdvancement.js 100.00% <100.00%> (ø)
...s/src/edit-story/components/panels/sizePosition.js 91.48% <0.00%> (+2.12%) ⬆️
assets/src/edit-story/elements/text/frame.js 97.50% <0.00%> (+2.50%) ⬆️
assets/src/edit-story/components/button/index.js 97.29% <0.00%> (+2.70%) ⬆️
...edit-story/components/panels/panel/shared/title.js 80.00% <0.00%> (+2.85%) ⬆️
...ponents/library/panes/media/media3p/media3pPane.js 93.75% <0.00%> (+3.12%) ⬆️
assets/src/edit-story/app/media/local/reducer.js 51.61% <0.00%> (+3.22%) ⬆️
...s/library/panes/media/media3p/media3pCategories.js 96.42% <0.00%> (+3.57%) ⬆️
assets/src/edit-story/app/media/local/actions.js 70.83% <0.00%> (+4.16%) ⬆️
assets/src/edit-story/elements/shared/index.js 100.00% <0.00%> (+4.16%) ⬆️
... and 178 more

@swissspidy swissspidy merged commit 9b4d389 into main Sep 8, 2020
@swissspidy swissspidy deleted the fix/4094-history-bug branch September 8, 2020 17:27
@miina
Copy link
Contributor Author

miina commented Sep 8, 2020

Props @swissspidy for looking into the failing tests + config issue which in the end came out to be a test issue instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants