New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix updating page advancement on the first load #4345
Conversation
Size Change: +34 B (0%) Total Size: 1.24 MB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works as expected!
There's an issue with Karma tests (#4364 ) which blocks merging this, however, sending to QA meanwhile already. |
Verified in QA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #4345 +/- ##
===========================================
+ Coverage 70.41% 83.33% +12.92%
===========================================
Files 842 842
Lines 14908 14909 +1
===========================================
+ Hits 10497 12424 +1927
+ Misses 4411 2485 -1926
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Props @swissspidy for looking into the failing tests + config issue which in the end came out to be a test issue instead. |
Summary
Relevant Technical Choices
To-do
User-facing changes
Testing Instructions
Fixes #4094
Fixes #1907