New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dashboard: Update tests to use new renderWithProviders test util #4427
Conversation
…e new render util
… util + merge conflicts
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
Codecov Report
@@ Coverage Diff @@
## main #4427 +/- ##
==========================================
- Coverage 83.08% 83.07% -0.01%
==========================================
Files 870 870
Lines 15313 15313
==========================================
- Hits 12723 12722 -1
- Misses 2590 2591 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this clean up is so nice! thanks for taking the time on this. Works great locally. Think there's just a linting issue with spacing that's getting flagged.
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
Summary
Update Tests to use new renderWithProviders test util
User-facing changes
None
Testing Instructions
Verify the JS unit tests pass in CI and locally