Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard: Update tests to use new renderWithProviders test util #4427

Merged
merged 26 commits into from Sep 11, 2020

Conversation

dmmulroy
Copy link
Contributor

@dmmulroy dmmulroy commented Sep 9, 2020

Summary

Update Tests to use new renderWithProviders test util

User-facing changes

None

Testing Instructions

Verify the JS unit tests pass in CI and locally

@github-actions
Copy link
Contributor

github-actions bot commented Sep 9, 2020

Size Change: 0 B

Total Size: 1.27 MB

ℹ️ View Unchanged
Filename Size Change
assets/css/edit-story.css 909 B 0 B
assets/css/stories-dashboard.css 939 B 0 B
assets/css/web-stories-embed-block.css 515 B 0 B
assets/js/chunk-web-stories-template-0-********************.js 10.2 kB 0 B
assets/js/chunk-web-stories-template-1-********************.js 10.3 kB 0 B
assets/js/chunk-web-stories-template-2-********************.js 10 kB 0 B
assets/js/chunk-web-stories-template-3-********************.js 10.5 kB 0 B
assets/js/chunk-web-stories-template-4-********************.js 10.6 kB 0 B
assets/js/chunk-web-stories-template-5-********************.js 6.86 kB 0 B
assets/js/chunk-web-stories-template-6-********************.js 9.91 kB 0 B
assets/js/chunk-web-stories-template-7-********************.js 9.78 kB 0 B
assets/js/chunk-web-stories-textset-0-********************.js 1.25 kB 0 B
assets/js/edit-story.js 502 kB 0 B
assets/js/stories-dashboard.js 597 kB 0 B
assets/js/web-stories-activation-notice.js 70.9 kB 0 B
assets/js/web-stories-embed-block.js 17.5 kB 0 B

compressed-size-action

@codecov
Copy link

codecov bot commented Sep 9, 2020

Codecov Report

Merging #4427 into main will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4427      +/-   ##
==========================================
- Coverage   83.08%   83.07%   -0.01%     
==========================================
  Files         870      870              
  Lines       15313    15313              
==========================================
- Hits        12723    12722       -1     
- Misses       2590     2591       +1     
Flag Coverage Δ
#karmatests 71.65% <ø> (-0.01%) ⬇️
#unittests 66.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ets/src/edit-story/app/media/pagination/reducer.js 45.00% <0.00%> (-5.00%) ⬇️

Copy link
Contributor

@BrittanyIRL BrittanyIRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this clean up is so nice! thanks for taking the time on this. Works great locally. Think there's just a linting issue with spacing that's getting flagged.

@google-cla
Copy link

google-cla bot commented Sep 11, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Sep 11, 2020
@carloskelly13
Copy link
Contributor

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Sep 11, 2020
@dmmulroy dmmulroy merged commit fd21ae9 into main Sep 11, 2020
@dmmulroy dmmulroy deleted the task/update-tests branch September 11, 2020 17:22
@swissspidy swissspidy added Group: Dashboard Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️ labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Group: Dashboard Type: Code Quality Things that need a refactor, rewrite or just some good old developer ❤️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants