Text Style: Reset font weight to regular on font family change #5360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +560 B (0%) Total Size: 1.5 MB
ℹ️ View Unchanged
|
zachhale
force-pushed
the
bug/1899-reset-font-weight
branch
from
4d222e5
to
88c97c7
Compare
Codecov Report
@@ Coverage Diff @@
## main #5360 +/- ##
==========================================
- Coverage 84.48% 84.47% -0.02%
==========================================
Files 1002 1003 +1
Lines 17647 17685 +38
==========================================
+ Hits 14909 14939 +30
- Misses 2738 2746 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
zachhale
requested review from
carloskelly13,
BrittanyIRL,
embarks and
maxyinger
…ly change"" This reverts commit c154176.
zachhale
force-pushed
the
bug/1899-reset-font-weight
branch
from
9ba7194
to
b89ff00
Compare
BrittanyIRL
approved these changes
Dec 3, 2020
Comment on lines
106
to
108
| pushUpdate(({ content }) => { | ||
| return { content: updater(content, ...args) }; | ||
| }, true), |
There was a problem hiding this comment.
nit: this doesn't need the brackets, can just keep it how it was I think?
| ); | ||
|
|
||
| // when selected elements update, run any queued pushes | ||
| useEffect(() => { |
|
OPE, looks like those tests were moved to a different file while I was working on this. Brought them back! |
carloskelly13
approved these changes
Dec 4, 2020
swissspidy
added
Elements: Text
Group: Style Panel
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bring back fix for #1899 and fix lingering bug. The original fix (#4900) implemented an almost complete fix, but left one bug which reverted any content changes in the currently editing text element when the font family was changed.
This PR re-applies the original fix and resolves the bug with content getting reverted when family changes.
Original fix PR: #4900
Revert PR: #5045
Relevant Technical Choices
This was a tricky one because the editor needs to get destroyed so that we can (1) set the font weight to the whole element and (2) make sure any content changes are saved first.
There's no way to have the appropriate content to clean up until after the editor closes, so this PR introduces a "queued push" concept that waits for
selectedElementsto update before resetting the font weight on the element.To-do
User-facing changes
Testing Instructions
Fixes #1899