-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Media Library: Display tooltips if transcoding is in progress #6566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swissspidy
added
Type: Enhancement
New feature or improvement of an existing feature
Group: Media
Group: Video Optimization
Media transcoding, compression and cropping
labels
Mar 1, 2021
Size Change: +51 B (0%) Total Size: 1.22 MB ℹ️ View Unchanged
|
swissspidy
force-pushed
the
add/6089-tooltip
branch
from
March 2, 2021 15:12
489ac67
to
239e9b1
Compare
New issue created - #6581 |
swissspidy
force-pushed
the
add/6089-tooltip
branch
from
March 2, 2021 15:43
239e9b1
to
a5d0238
Compare
spacedmonkey
approved these changes
Mar 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
swissspidy
force-pushed
the
add/6089-tooltip
branch
from
March 9, 2021 08:34
a5d0238
to
f92ce61
Compare
Codecov Report
@@ Coverage Diff @@
## main #6566 +/- ##
===========================================
+ Coverage 68.58% 82.78% +14.19%
===========================================
Files 1128 1131 +3
Lines 20010 20038 +28
===========================================
+ Hits 13724 16588 +2864
+ Misses 6286 3450 -2836
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Group: Media
Group: Video Optimization
Media transcoding, compression and cropping
Type: Enhancement
New feature or improvement of an existing feature
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We want to display a tooltip if video optimization is in progress for a given element/resource.
Summary
This PR adds a tooltip for resources in the media library which are still being transcoded.
I was not able to do the same on the canvas, as neither the frame nor the display layer worked well with the tooltip's absolute positioning.
Relevant Technical Choices
To-do
User-facing changes
New tooltip when hovering over media items in the library:
Testing Instructions
QA
This PR can be tested by following these steps:
UAT
This PR can be tested by following these steps:
Reviews
Does this PR have a security-related impact?
No
Does this PR change what data or activity we track or use?
No
Does this PR have a legal-related impact?
No
Checklist
Type: XYZ
label to the PRFixes #6089