Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable support for Google Cloud Endpoints #18

Merged
merged 2 commits into from
Aug 7, 2014
Merged

Enable support for Google Cloud Endpoints #18

merged 2 commits into from
Aug 7, 2014

Conversation

Scarygami
Copy link
Contributor

* Root URL for loading a Google Cloud Endpoints API.
* A valid root URL looks like this:
* 'https://your_app_id.appspot.com/_ah/api'
* @attribute root
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make this just param something like appId instead,...and not require the user to set a full URL?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, this will work since cloud endpoints don't support custom domains, so the URL format is fixed anyway.

@Scarygami
Copy link
Contributor Author

Hmmm, thinking about it there's one scenario when you would need a different root URL:
When testing in local dev-environment you would use http://localhost:port/_ah/api

Should I add both root and appId attributes?

And which one would be better to have higher priority?

  1. Overwrite root when an appId is present, or
  2. ignore appId when root is present (I think this option would be better)

@ebidel
Copy link
Contributor

ebidel commented Aug 7, 2014

appId = localhost:port would still work. We can probably just document that case for local dev. WDYT?

@Scarygami
Copy link
Contributor Author

With the current implementation this would result in https://localhost:port.appspot.com/_ah/api which would fail.

@ebidel
Copy link
Contributor

ebidel commented Aug 7, 2014

Right sorry. Maybe this should be a cloudEndpointHost param?

@Scarygami
Copy link
Contributor Author

Hmmm, the simplicity of just having the appId is nice though.
Maybe leave it like this for now, since it covers most use-cases, and keep it in mind as further enhancement?

From my experience testing cloud endpoints on the local dev-server is a little bit wonky anyway, and not quite the same like running it directly on App Engine.

@ebidel
Copy link
Contributor

ebidel commented Aug 7, 2014

Future improvement :) Mind logging a bug so we can keep track of it?

ebidel added a commit that referenced this pull request Aug 7, 2014
Enable support for Google Cloud Endpoints
@ebidel ebidel merged commit 5c82059 into GoogleWebComponents:master Aug 7, 2014
@Scarygami Scarygami deleted the cloud-endpoints-support branch August 7, 2014 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants