Update element to use signin-aware #6
Conversation
| @@ -96,7 +95,7 @@ | |||
| */ | |||
| displayCalendars: function() { | |||
| if (this.signedIn && this.$.calendar.api) { | |||
| var request = this.$.calendar.api.calendarList.list(); | |||
| var request = this.$.calendar.api.calendarList.list({"key": ""}); | |||
There was a problem hiding this comment.
Reasoning for the {"key": ""} parameter:
On the demo page another element is included that only uses an apiKey by setting gapi.client.setApiKey
In some cases (not consistently) some Google API methods return a 401 invalid credentials error when both an Authorization header and a key=xxx query parameter are provided (there's an issue open for that somewhere for quite a while already...), and I actually ran into this issue while testing.
To prevent this I explicitly set the key query parameter to be empty here, overwriting the default that would come from gapi.auth.setApiKey
|
@devnook can you take a look at this? |
|
@Scarygami This one will also need to be rebased before it can be merged in if we go ahead with it. |
|
Rebase done 👍 |
|
Thank you! |
|
ping @devnook |
|
Merging in as changes LGTM and there's value in getting this in before PRs build up. cc @devnook in case there's anything you think needs further work or requires a revert. |
Update element to use signin-aware
|
@addyosmani would it make sense if I send PRs to other elements using the signin element to update them to signin-aware as well, or will you discuss/update this internally first? |
|
Yes please :) I think it makes sense to update the other elements to use signin-aware and I'm happy to help cc in the right folks as an fyi who would be useful to sanity check on reviews. |
As discussed with @addyosmani at GoogleWebComponents/google-signin#11
My suggestion how to change/use the google-calendar element to allow for one signin button on the page and no authentication interference between multiple elements.