-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-map-poly
watches child elements
#347
Conversation
`google-map-poly` watches the lat/lng properties of it's child elements
I've made these changes in my own bower install of |
Because I already fixed this in my own install, I didn't bother to create an issue for it. However, I should provide some explanation for this PR...
<google-map-poly>
<google-map-point latitude$="{{p1.lat}}" longitude$="{{p1.lng}}"></google-map-point>
<google-map-point latitude$="{{p2.lat}}" longitude$="{{p2.lng}}"></google-map-point>
</google-map-poly> |
Where is the GoogleWebComponent team? |
@e111077 Is anyone watching this project anymore? |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Heya GWC elements are maintained by individual googlers (not on the polymer team) that have decided to make and open source elements. It may be that they may have moved from their teams, left google, or simply forgot about these elements. The polymer team occasionally takes a look at these elements when it comes to huge breaking bugs. I can take a look at this PR, but due to other work pulling me in the other direction right now, I won't be able to get to it this week. In the meantime, you may be able to just fork the element, make changes and then bower install it from your release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a great PR!
I just need you to resolve that CLA issue though |
google-map-poly
watches the lat/lng properties of it's child elements for updated properties