Zooming in/out the map updates zoom value. Fixes #59. #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -546,7 +546,7 @@ | |||
| }, | |||
|
|
|||
| zoomChanged: function() { | |||
| if (this.map) { | |||
| if (this.map && this.map.getZoom() !== this.zoom) { | |||
There was a problem hiding this comment.
Do you need to do this check?
There was a problem hiding this comment.
Not really. Google Maps ignores the request if the new value is the same as the current value. I just have a habit of checking the new != old before setting values, incase implementation doesn't handle it or changes.
I can remove the check if you feel it's unnecessary.
There was a problem hiding this comment.
Let's remove an save the function call.
ebidel
added a commit
that referenced
this pull request
Oct 7, 2014
Zooming in/out the map updates zoom value. Fixes #59.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for
zoom_changedevents and update the map zoom level if new value is not equal to the old value.