Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows a preferred language to be specified fixes issue #77 #85

Closed
wants to merge 4 commits into from

Conversation

L1eselB
Copy link

@L1eselB L1eselB commented Dec 10, 2014

Passes language through to the google-maps-api and allows people to specify a language to display the map in.

* The localized language to load the Maps API with. For more information
* see https://developers.google.com/maps/documentation/javascript/basics#Language
*
* Note: the Maps API defaults to the preffered language setting of the browser.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

preferred

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@ebidel
Copy link
Contributor

ebidel commented Dec 10, 2014

Thanks! Just the typo.

@ebidel
Copy link
Contributor

ebidel commented Dec 11, 2014

Can you rebase and fix the typo?

@ebidel ebidel mentioned this pull request Dec 11, 2014
@ebidel
Copy link
Contributor

ebidel commented Feb 5, 2015

Sorry of the delay on this. Can you rebase again :(

@googlebot
Copy link

Thanks for your pull request.

It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check the information on your CLA or see this help article on setting the email on your git commits.

Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name.

@L1eselB
Copy link
Author

L1eselB commented Feb 5, 2015

Done, please take a look, is there anything else I need to do?

@ebidel
Copy link
Contributor

ebidel commented Feb 5, 2015

Have you signed the CLA?

@L1eselB
Copy link
Author

L1eselB commented Feb 6, 2015

Yes I have

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Feb 6, 2015
@ebidel
Copy link
Contributor

ebidel commented Feb 6, 2015

Indeed. Thanks. Can you rebase?

@ebidel
Copy link
Contributor

ebidel commented Mar 2, 2015

Ping? Still needs a rebase

@ebidel
Copy link
Contributor

ebidel commented Mar 19, 2015

Added in #117

@ebidel ebidel closed this Mar 19, 2015
@msp
Copy link

msp commented Mar 28, 2016

Hello!

New message, please read http://leepak.org/himself.php?fajcl

info@radialsolutions.co.uk

@msp
Copy link

msp commented Mar 28, 2016

Hello!

New message, please read http://m-moneys.com/of.php?1w

info@radialsolutions.co.uk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants