-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The accepted case exact value for "binary" should be "true" #69
Comments
Thanks for raising that the case exact should be "true". Note, PR has been updated to address this. |
I noticed, "x509Certificates.value" attribute of user core schema is not case sensitive, this contradicts statement here https://tools.ietf.org/html/rfc7643#section-2.3.6 , |
The good news is, this library does not validate against the core schema, as proven by the green tests, so the recent change should not break everything due to "x509Certificates.value". However, it would affect the projects currently using binary attributes in the extension schemas. "ReferenceAttribute" also face a similar issue with the "True" expectation of case-exact. I have captured this information in an email to scim-chairs@ietf.org for advice. |
I tried the email from the rfc and it bounced back from the email server, and the email noted above has seemingly gone into a blackhole (for now). Another look at the definition of case exact, it suggests that it is applicable for string attribute, e.g.
Then it is quite strange it was explicitly mentioned it on the binary and reference attribute definition. On this note, declaration of 'True' case exact still stands to be sensible; to honour the explicit nature of Python. That can be done by extending the class with an overriding method. Feel free to feedback and I will give it a couple of days/ weeks on hold as YAGNI for now. |
Closing due to the lack of updates |
Hi @GordonSo ,
According to https://tools.ietf.org/html/rfc7643#section-2.3.6, the binary value should be case exact, but module expects value to be false.
In Class BinaryAttribute, the following change should be made, _accepted_case_exact_value = {True}
Regards,
Mohan
The text was updated successfully, but these errors were encountered: