Adding support for the mobile/force paginator flag #111
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Some users dislike the new file output, and would rather have paginators.
It's also not a viable option to have as the only option, as a lot of people use mobile, and there's no file preview option on mobile.
The best way to view these files on mobile is downloading them, finding them in the file system, and figuring out what app to open in.
Summary of changes made
I created a new
.env
flag, titledJISHAKU_FORCE_PAGINATOR
which would force the output to use paginator regardless of device.I also added a check for
ctx.author.is_on_mobile()
, in which case it will default to paginators on mobile regardless of the flag setting.These checks were placed everywhere there is a check for
len(result) < 50_000
(features/[filesystem|invocation|python].py
,flags.py
)I don't believe I missed any, but please add it if I did :)
Checklist