Feature/symfony upgrade to.3.4 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t brake with older versions of node
Dockerfile set grunt-cli@1.3.2
…fony/security which replaces thr former one. Thanks to that, symfony/security can be safely updated to 2.8.52 .
…e now updatable to 2.8.52
Renew SSL certs until 2026
…ny-packages-to-last-minor-versions Remove update restriction for some Symfony packages
* Added missing PDO dependency which is in fact needed * Fixed Sponsor model unit tests * Removed pointless comments and deprecated method on Mail model * Fixed Mail model unit tests * Fixed TextTest translations tests due to missing and/or incorrect HTML tags/attributes * Updated Matcher model tests * Enforce PHP 7.1 as minimum PHP version in Composer * Fixed HTML structure on newsletter template and removed commented CSS classes * Improved readability, added parameter types and some small refactors on Mail model * Improved readability and added parameter types on MatcherTest class * Further cleanup on User and MatcherTest classes * Downgraded minimum PHP version to the production one * Reintroduced sqlWhere variable so we don't get errors since it's used in the code * Fully reintroduced the Sponsor 'type' property and fixed related failing test * Refactored call to obtain Sponsors list into a method * Fix SQL query to obtain Sponsors list * Fix Mail model tests along with issues on the HTML formatting with 2 related templates * Changed method syntax so is PHP 7.0 compliant (it was using PHP 7.1 syntax) * Fix Matcher model tests (some translations were missing when querying for them) * Reduced tests verbosity (we don't need to know if users, projects, etc were removed when running tests) * Ignored .idea (Jetbrains IDEs) folder
…cus passed, failed, errored or were skipped
…. Flipped assertEquals comparators to be compliant with expected/actual order.
* add deployer script * refactor subdomain processing and add test to it (#205) * fix/var subs (#215) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix/var subs (#216) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix namespace * update oauth library for linkedin * update up to a working commit * fix linkedin call
…n PHPUnits successfully)
* fix install of grunt-cli to only install the 1.3.2 so that it does not brake with older versions of node * Renew SSL certs until 2026 * Removed symfony/security-csrf package since it was colliding with symfony/security which replaces thr former one. Thanks to that, symfony/security can be safely updated to 2.8.52 . * Removed enforcement to keep some Symfony package in v2.8.0 so they are now updatable to 2.8.52 * Added (un)zip packages to Dockerfile so we remove Composer warning (#170) * Bug/fix unit tests (#171) * Added missing PDO dependency which is in fact needed * Fixed Sponsor model unit tests * Removed pointless comments and deprecated method on Mail model * Fixed Mail model unit tests * Fixed TextTest translations tests due to missing and/or incorrect HTML tags/attributes * Updated Matcher model tests * Enforce PHP 7.1 as minimum PHP version in Composer * Fixed HTML structure on newsletter template and removed commented CSS classes * Improved readability, added parameter types and some small refactors on Mail model * Improved readability and added parameter types on MatcherTest class * Further cleanup on User and MatcherTest classes * Downgraded minimum PHP version to the production one * Reintroduced sqlWhere variable so we don't get errors since it's used in the code * Fully reintroduced the Sponsor 'type' property and fixed related failing test * Refactored call to obtain Sponsors list into a method * Fix SQL query to obtain Sponsors list * Fix Mail model tests along with issues on the HTML formatting with 2 related templates * Changed method syntax so is PHP 7.0 compliant (it was using PHP 7.1 syntax) * Fix Matcher model tests (some translations were missing when querying for them) * Reduced tests verbosity (we don't need to know if users, projects, etc were removed when running tests) * Ignored .idea (Jetbrains IDEs) folder * Bumped PHPMailer to 6.x and fixed Mail model and test with related changes * Bumped Mockery to 1.x * Added OpenSSL extension, since it's used by AmazonSns and AuthListener classes * Updated amazon-s3-php-class with many changes (last updated on 2015) * Assure PHPMailer minimum version is 6.4 * Updated to PHPUnit 6.5 * Removed empty test along with unused imports * Moved PHP extensions on composer file right after the PHP version for easy spotting * Reduced verbosity on tests output so we can focus on seeing if the focus passed, failed, errored or were skipped * Remove deprecated asserts and upgrade PHPUnit from 6.x to 7.x * Bumped min PHP version to 7.1 * Upgrade PHP from 7.0/7.1 to 7.4 * Upgraded PHPUnit to 8.x (depends on PR that enforces PHP 7.4) * Removed deprecated expectedException (will be removed on PHPUnit 9.x). Flipped assertEquals comparators to be compliant with expected/actual order. * Removed deprecated class * Got rid of last array curly braces access * Removed duplicated key * Removed deprecated (and unused) FlattenException import * Removed last noisy message on PHPUnit so we only have test results status * WIP Upgrade to Symfony 3.x * Tidy index(_env).php files so they have less differences between them, for a future merge * Got rid of index_dev.php in favor of index.php that read ENV DEBUG parameter * Added import, rewritten some PHPDocs and added some return types * Clean container.php * Refactor getName() method from custom Symfony Form Types, so they just have getBlockPrefix() method * Refactor to add Form Types as is required in Symfony 3 * Fix install of migrations on PHP 7.4 and latest Composer dependencies * Fix RouteListener initialization. Fix DB setup. * Use ::class to register services in the ServiceContainer instead of strings * Fix composer.json so it reckognizes goteo-private tests * Fix tests for App class (due to having renamed a property) * Updated Omnipay dependency to the new one from league * Grouped Composer dependencies * Used Symfony HttpKernel class instead of HttpKernel\HttpKernel * Removed unneeded package * Cleanup Omnipay classes and fix some issues while initilizing the Payment Gateway * Made final changes to support all Omnipay payment methods using Omnipay v3 * Deprecated static AbstractPaymentMethod::getId() method in favor of non static one * Converted static calculateComission method into non-static calculateCommission * Converted static AbstractPaymentMethod::isInternal() into a non-static method * Add parameter / return types and import used classes * Updated TelegramBot so it doesn't use deprecated code * Reviewed controllers to ensure they follow Symfony 3 convention * Add User property type * Removed unused code * Tidy up classes * Removed unused parameters from PHPDoc * Upgraded Symfony from 3.0 to 3.1 * Included some used classes * Finalize migration to symfony/forms 3.x (there must be a getBlockPrefix() method on a new Type, even if their parents have the method * Enforce getModelForm() & createFormBuilder() from controllers to return FormProcessorInterface & FormFactory respectively * Fix return parameter of Controller::createFormBuilder() method and the controllers that inherit it * Upgraded to Symfony 3.2 * Symfony packages upgraded to 3.3 * WIP Migration to Symfony 3.4 almost completed * Fix call to Mail::renderEmailTemplate (got renamed recently) * Fix Settings Dashboard form (ChoiceType elements had flipped key / values) * Fix loading of ChoiceType and some minor refactors * Fix ChoiceType for some forms related to Contract PersonDocumentTypes * Revert BooleanType::getBlockPrefix() method so it returns 'boolean' which to match it's class name * Refactor ProjectOverviewForm to fix it and to ease its reading * Fix import of PDOException (it was written incorrectly) * Fix ChoiceTypes on several Project related forms * Refactor to use the new Controller:getModelForm() method that requires a class instead of just a string. Fixed some Symfony Forms due to incomplete migration when Symfony 3.0 upgrade. * Refactored last controller that used the deprecated method to guess SymfonyForm class * Tiny refactors * Removed unnecessary EventDispatcher from Console class * Clean up of some classes * Change test to testLegacy, since the deprecation notice is due to Symfony code (and is due to expire on Symfony 4.3) * Fix some Symfony Forms with unfinished migration to Symfony 3.x. Remove some unused code / comments. * General cleanup of controllers * Tiny cleanup * Fix access to some admin pages * Fix usage of DatepickerType so it actually replaces the Symfony type while keeping all it's parents features * Fix admin blog add/edit form * Fix behaviour of some custom Symfony Form Types * Fix FilterForm so it conforms to Symfony 3.x standards * Readd workshop_location table since it got removed sometime ago by mistake * Fix Symfony Console (probably due to some incomplete step after migrating to Symfony 3.x) * Fix admin workshop add/edit form * Fix some translations * Refactor Sponsors controller * Fix broken CSS on Call edit form for rewards items * Fix admin Stories add/edit form * Fix CSS error while displaying TypeaheadType form elements * Fix Controller::redirect() parameter types * Fix admin Channel Questionnaire and Channel Section forms to add/edit * Fix Admin Charts API controller * Cleanup SessionListener * Reformatted Filter and Project models * Simplify public/index.php * Cleanup main PHP classes * Minor refactors on controllers * Removed deprecated mcrypt PHP extension * Removed deprecated mcrypt PHP extension from composer.lock * Fix SQL migration * Fix SQL migration related to mail table * Fix SQL migration related to mail table * Fix SQL migration related to mail table * Improved Docker readme * Moved Omnipay/Mock/Gateway class to goteo repository (is needed to run PHPUnits successfully) Co-authored-by: Javier <javicarrillo83@gmail.com> Co-authored-by: David Igón <david@goteo.org> Co-authored-by: Ivan Vergés <ivan@platoniq.net>
* fix install of grunt-cli to only install the 1.3.2 so that it does not brake with older versions of node * Renew SSL certs until 2026 * Removed symfony/security-csrf package since it was colliding with symfony/security which replaces thr former one. Thanks to that, symfony/security can be safely updated to 2.8.52 . * Removed enforcement to keep some Symfony package in v2.8.0 so they are now updatable to 2.8.52 * Added (un)zip packages to Dockerfile so we remove Composer warning (#170) * Bug/fix unit tests (#171) * Added missing PDO dependency which is in fact needed * Fixed Sponsor model unit tests * Removed pointless comments and deprecated method on Mail model * Fixed Mail model unit tests * Fixed TextTest translations tests due to missing and/or incorrect HTML tags/attributes * Updated Matcher model tests * Enforce PHP 7.1 as minimum PHP version in Composer * Fixed HTML structure on newsletter template and removed commented CSS classes * Improved readability, added parameter types and some small refactors on Mail model * Improved readability and added parameter types on MatcherTest class * Further cleanup on User and MatcherTest classes * Downgraded minimum PHP version to the production one * Reintroduced sqlWhere variable so we don't get errors since it's used in the code * Fully reintroduced the Sponsor 'type' property and fixed related failing test * Refactored call to obtain Sponsors list into a method * Fix SQL query to obtain Sponsors list * Fix Mail model tests along with issues on the HTML formatting with 2 related templates * Changed method syntax so is PHP 7.0 compliant (it was using PHP 7.1 syntax) * Fix Matcher model tests (some translations were missing when querying for them) * Reduced tests verbosity (we don't need to know if users, projects, etc were removed when running tests) * Ignored .idea (Jetbrains IDEs) folder * Bumped PHPMailer to 6.x and fixed Mail model and test with related changes * Bumped Mockery to 1.x * Added OpenSSL extension, since it's used by AmazonSns and AuthListener classes * Updated amazon-s3-php-class with many changes (last updated on 2015) * Assure PHPMailer minimum version is 6.4 * Updated to PHPUnit 6.5 * Removed empty test along with unused imports * Moved PHP extensions on composer file right after the PHP version for easy spotting * Reduced verbosity on tests output so we can focus on seeing if the focus passed, failed, errored or were skipped * Remove deprecated asserts and upgrade PHPUnit from 6.x to 7.x * Bumped min PHP version to 7.1 * Upgrade PHP from 7.0/7.1 to 7.4 * Upgraded PHPUnit to 8.x (depends on PR that enforces PHP 7.4) * Removed deprecated expectedException (will be removed on PHPUnit 9.x). Flipped assertEquals comparators to be compliant with expected/actual order. * Removed deprecated class * Got rid of last array curly braces access * Removed duplicated key * Removed deprecated (and unused) FlattenException import * Removed last noisy message on PHPUnit so we only have test results status * WIP Upgrade to Symfony 3.x * Tidy index(_env).php files so they have less differences between them, for a future merge * Got rid of index_dev.php in favor of index.php that read ENV DEBUG parameter * Added import, rewritten some PHPDocs and added some return types * Clean container.php * Refactor getName() method from custom Symfony Form Types, so they just have getBlockPrefix() method * Refactor to add Form Types as is required in Symfony 3 * Fix install of migrations on PHP 7.4 and latest Composer dependencies * Fix RouteListener initialization. Fix DB setup. * Use ::class to register services in the ServiceContainer instead of strings * Fix composer.json so it reckognizes goteo-private tests * Fix tests for App class (due to having renamed a property) * Updated Omnipay dependency to the new one from league * Grouped Composer dependencies * Used Symfony HttpKernel class instead of HttpKernel\HttpKernel * Removed unneeded package * Cleanup Omnipay classes and fix some issues while initilizing the Payment Gateway * Made final changes to support all Omnipay payment methods using Omnipay v3 * Deprecated static AbstractPaymentMethod::getId() method in favor of non static one * Converted static calculateComission method into non-static calculateCommission * Converted static AbstractPaymentMethod::isInternal() into a non-static method * Add parameter / return types and import used classes * Updated TelegramBot so it doesn't use deprecated code * Reviewed controllers to ensure they follow Symfony 3 convention * Add User property type * Removed unused code * Tidy up classes * Removed unused parameters from PHPDoc * Upgraded Symfony from 3.0 to 3.1 * Included some used classes * Finalize migration to symfony/forms 3.x (there must be a getBlockPrefix() method on a new Type, even if their parents have the method * Enforce getModelForm() & createFormBuilder() from controllers to return FormProcessorInterface & FormFactory respectively * Fix return parameter of Controller::createFormBuilder() method and the controllers that inherit it * Upgraded to Symfony 3.2 * Symfony packages upgraded to 3.3 * WIP Migration to Symfony 3.4 almost completed * Fix call to Mail::renderEmailTemplate (got renamed recently) * Fix Settings Dashboard form (ChoiceType elements had flipped key / values) * Fix loading of ChoiceType and some minor refactors * Fix ChoiceType for some forms related to Contract PersonDocumentTypes * Revert BooleanType::getBlockPrefix() method so it returns 'boolean' which to match it's class name * Refactor ProjectOverviewForm to fix it and to ease its reading * Fix import of PDOException (it was written incorrectly) * Fix ChoiceTypes on several Project related forms * Refactor to use the new Controller:getModelForm() method that requires a class instead of just a string. Fixed some Symfony Forms due to incomplete migration when Symfony 3.0 upgrade. * Refactored last controller that used the deprecated method to guess SymfonyForm class * Tiny refactors * Removed unnecessary EventDispatcher from Console class * Clean up of some classes * Change test to testLegacy, since the deprecation notice is due to Symfony code (and is due to expire on Symfony 4.3) * Fix some Symfony Forms with unfinished migration to Symfony 3.x. Remove some unused code / comments. * General cleanup of controllers * Tiny cleanup * Fix access to some admin pages * Fix usage of DatepickerType so it actually replaces the Symfony type while keeping all it's parents features * Fix admin blog add/edit form * Fix behaviour of some custom Symfony Form Types * Fix FilterForm so it conforms to Symfony 3.x standards * Readd workshop_location table since it got removed sometime ago by mistake * Fix Symfony Console (probably due to some incomplete step after migrating to Symfony 3.x) * Fix admin workshop add/edit form * Fix some translations * Refactor Sponsors controller * Fix broken CSS on Call edit form for rewards items * Fix admin Stories add/edit form * Fix CSS error while displaying TypeaheadType form elements * Fix Controller::redirect() parameter types * Fix admin Channel Questionnaire and Channel Section forms to add/edit * Fix Admin Charts API controller * Cleanup SessionListener * Reformatted Filter and Project models * Simplify public/index.php * Cleanup main PHP classes * Minor refactors on controllers * Removed deprecated mcrypt PHP extension * Removed deprecated mcrypt PHP extension from composer.lock * Fix SQL migration * Fix SQL migration related to mail table * Fix SQL migration related to mail table * Fix SQL migration related to mail table * Improved Docker readme * make loggin resilient to Gelf updates failures (#225) * make loggin resilient to Gelf updates failures * ignore redundant exception thrown * fix on deprecated implode call (#229) * update oauth library for linkedin (#226) * add deployer script * refactor subdomain processing and add test to it (#205) * fix/var subs (#215) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix/var subs (#216) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix namespace * update oauth library for linkedin * update up to a working commit * fix linkedin call * remove orphan location stats (#230) * Moved Omnipay/Mock/Gateway class to goteo repository (is needed to run PHPUnits successfully) Co-authored-by: Javier <javicarrillo83@gmail.com> Co-authored-by: David Igón <david@goteo.org> Co-authored-by: Ivan Vergés <ivan@platoniq.net> Co-authored-by: David <david.igon@riseup.net>
…dation/goteo into feature/symfony-upgrade-to.3.4
* Add sign_url field to Project and to Project Forms * Make new project fields not required * Add signture button in project skin * Fix signature css * Fix css and target blank link Co-authored-by: Javier Carrillo <javier@goteo.org> Co-authored-by: David Igón <david@goteo.org>
* Display cursor at current tab projects' button on homepage * Display cursor at current tab projects' button on homepage
* add deployer script * update symfony to ^2.8 * remove url from dropfiles in forms * make uploadimagetransformer save image so that it updates the file name * some fixes * fix user profile form to save avatar * rework of dropfiles type and js * rework of all forms with dropfiles * small fixes in model transformers * refactor subdomain processing and add test to it (#205) * fix/var subs (#215) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix/var subs (#216) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix namespace * update oauth library for linkedin * fix/linkedin (#227) * Update live base code with latest fixes (#218) * add project name to project translate overview * fix route of poster in project dashboard * Upgraded Symfony packages to v2.8.30 (last working version) * Fix call to render method since it was renamed (cherry picked from commit 5d93afa) * add composer.lock * restore a early die if misconfiguration * Updated Dockerfile to use an Ubuntu image that's not deprecated (#181) * Updated Dockerfile to use an Ubuntu image that's not deprecated * Removed Docker image based on date in favour of one that won't change * fix/composer lock (#185) * Fix call to render method since it was renamed (cherry picked from commit 5d93afa) * remove lock to force deploy Co-authored-by: Carlos Alberto Martínez Gadea <carlosmartinezgadea@gmail.com> * Twitter card meta description fix * change projects to be shown in map when a matcher is selected to use node configuration if available * improve filters in discover and fix ajax query (cherry picked from commit 0432ebb325b99d68c42e300493fca974a6142c0f) * fix use of query parameters when they are not being used * fix project filters in discover and use of inner joins in project get list function * Add matcher completed status * Fix icons size * Fix user leave exceptions * remove comment on sql project name selects * fix missing ) on fallback lang in Project published * fix on config test yaml with env parameters * add entries in docker settings to be used in yaml test * change in config test to use real yaml instead of inserting env variables * fix removing log in public index since its done via plugin Co-authored-by: Carlos Alberto Martínez Gadea <carlosmartinezgadea@gmail.com> Co-authored-by: Ivan Vergés <ivan@platoniq.net> Co-authored-by: Javier <javicarrillo83@gmail.com> Co-authored-by: Javier Carrillo <javier@goteo.org> * specify region before connecting to s3 (#219) * fix on deprecated parse_str without variable (#221) * make loggin resilient to Gelf updates failures (#225) * make loggin resilient to Gelf updates failures * ignore redundant exception thrown * update oauth library for linkedin Co-authored-by: David <david.igon@riseup.net> Co-authored-by: Carlos Alberto Martínez Gadea <carlosmartinezgadea@gmail.com> Co-authored-by: Javier <javicarrillo83@gmail.com> Co-authored-by: Javier Carrillo <javier@goteo.org> * update up to a working commit * fix linkedin call * remove unnecessary comments from Forms * Fix AdminStoryEdit form so it can properly add, save and remove the 3 types of images it has * Refactor to have a unique place where to handle additions, changes or removals of pictures on a form * Fix ProjectPostForm so it adds, edits and removes pictures correctly * add sign_url field to Project and to Project Forms * make new project fields not required * Add signture button in project skin * [STAGING deploy] Feature: Project can share a url to a signature platform (#235) * fix on deprecated implode call (#229) * update oauth library for linkedin (#226) * add deployer script * refactor subdomain processing and add test to it (#205) * fix/var subs (#215) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix/var subs (#216) * refactor subdomain processing and add test to it (#204) * refactor subdomain processing and add test to it * add other envs to deployment * make config process deep ENV substitution * fix namespace * update oauth library for linkedin * update up to a working commit * fix linkedin call * remove orphan location stats (#230) * fix on deprecated implode call in Check (#233) * add sign_url field to Project and to Project Forms * make new project fields not required * Add signture button in project skin Co-authored-by: Ivan Vergés <ivan@platoniq.net> Co-authored-by: Javier Carrillo <javier@goteo.org> * Fix signature css * Fix css and target blank link * update composer.lock to symfony 2.8.52 * Fix AdminSdgEdit form in order to allow removing the Sdf icon * Fix ProjectStory form, since it wasn't possible to upload, update or remove images to the ProjectStory * Fix Questionnaire form so it saves the uploaded image ID as the answer for Dropfiles * fixes on questionnaire form to handle upload of documents instead of images * Refactor on DropfilesType to include constant and to separate the different view elements added as a DropfilesType Co-authored-by: Ivan Vergés <ivan@platoniq.net> Co-authored-by: Carlos Alberto Martínez Gadea <carlosmartinezgadea@gmail.com> Co-authored-by: Javier <javicarrillo83@gmail.com> Co-authored-by: Javier Carrillo <javier@goteo.org>
…de-to.3.4 # Conflicts: # composer.json # composer.lock # src/Goteo/Controller/Admin/ChannelCriteriaAdminController.php # src/Goteo/Library/Forms/Admin/AdminChannelResourceEditForm.php # src/Goteo/Library/Forms/Admin/AdminFootprintEditForm.php # src/Goteo/Library/Forms/Admin/AdminSdgEditForm.php # src/Goteo/Library/Forms/Admin/AdminSectionForm.php # src/Goteo/Library/Forms/Admin/AdminSocialCommitmentEditForm.php # src/Goteo/Library/Forms/Admin/AdminSphereEditForm.php # src/Goteo/Library/Forms/Admin/AdminStoryEditForm.php # src/Goteo/Library/Forms/Admin/AdminWorkshopEditForm.php # src/Goteo/Library/Forms/Model/ProjectPostForm.php # src/Goteo/Library/Forms/Model/ProjectStoryForm.php # src/Goteo/Library/Forms/Model/QuestionnaireCreateForm.php # src/Goteo/Library/Forms/Model/QuestionnaireForm.php # src/Goteo/Library/Forms/Model/UserProfileForm.php # src/Goteo/Model/Project.php
…dation/goteo into feature/symfony-upgrade-to.3.4
davidbeig
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.