Feature/symfony upgrade to.3.4 #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t brake with older versions of node
Dockerfile set grunt-cli@1.3.2
…fony/security which replaces thr former one. Thanks to that, symfony/security can be safely updated to 2.8.52 .
…e now updatable to 2.8.52
Renew SSL certs until 2026
…ny-packages-to-last-minor-versions Remove update restriction for some Symfony packages
* Added missing PDO dependency which is in fact needed * Fixed Sponsor model unit tests * Removed pointless comments and deprecated method on Mail model * Fixed Mail model unit tests * Fixed TextTest translations tests due to missing and/or incorrect HTML tags/attributes * Updated Matcher model tests * Enforce PHP 7.1 as minimum PHP version in Composer * Fixed HTML structure on newsletter template and removed commented CSS classes * Improved readability, added parameter types and some small refactors on Mail model * Improved readability and added parameter types on MatcherTest class * Further cleanup on User and MatcherTest classes * Downgraded minimum PHP version to the production one * Reintroduced sqlWhere variable so we don't get errors since it's used in the code * Fully reintroduced the Sponsor 'type' property and fixed related failing test * Refactored call to obtain Sponsors list into a method * Fix SQL query to obtain Sponsors list * Fix Mail model tests along with issues on the HTML formatting with 2 related templates * Changed method syntax so is PHP 7.0 compliant (it was using PHP 7.1 syntax) * Fix Matcher model tests (some translations were missing when querying for them) * Reduced tests verbosity (we don't need to know if users, projects, etc were removed when running tests) * Ignored .idea (Jetbrains IDEs) folder
…cus passed, failed, errored or were skipped
…. Flipped assertEquals comparators to be compliant with expected/actual order.
* bump grunt version and grunt-contrib-uglify to support ECMAScript2016 * set grunt-cli to @1.4.0 since 1.4.1 uses node >= 10
…re is only one round (#252)
…dation/goteo into feature/symfony-upgrade-to.3.4
…alan dialect, as is the chosen one
…or the fields of each questionnaire, even old ones
…legacy and which are not
…i and handle input errors on client side (#253)
* fix call CallProject::calledMini to use string project instead of Project instance * fix query of Call using fetchObject
…if its allowed to comment (#261)
…del (goteo-private class)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.