-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impact data model #298
Merged
Merged
Impact data model #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 5d93afa)
* Updated Dockerfile to use an Ubuntu image that's not deprecated * Removed Docker image based on date in favour of one that won't change
* Fix call to render method since it was renamed (cherry picked from commit 5d93afa) * remove lock to force deploy Co-authored-by: Carlos Alberto Martínez Gadea <carlosmartinezgadea@gmail.com>
…node configuration if available
Add matcher as parameter in map controller See merge request dev/goteo!72
(cherry picked from commit 0432ebb325b99d68c42e300493fca974a6142c0f)
Fix discover filters See merge request dev/goteo!74
Fix discover location use See merge request dev/goteo!75
Rewrite project poster url See merge request dev/goteo!76
…pactdatarelations trait
…impact_data_model
…impact_data_model
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
lang | ||
FROM impact_data | ||
$joins | ||
WHERE id = :id"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the next time that we need to create a new model, I would strongly suggest that we take the time to configure Doctrine ORM and we start using it for that model.
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
carlos-mg89
reviewed
Nov 23, 2021
javicarrillo
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We have created an Impact Data model that is meant to be used by other classes using the ImpactDataRelationshipTrait.
Why?
To be able to create data for every model about their impact
How?
Creating a table to store data related to impact and a Trait that can be used by other classes.
Testing?
Screenshots (optional)
Anything Else?