Shorten urls in the base classes #1040
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With only one exception, this method is only used to process urls which are going to be passed to `IssueService.build_annotations` and `Issue.build_default_description`. There are a few benefits to doing this in the base classes instead: - DRYer, one less thing to worry about in service implementations, and more reliable -- I'm pretty sure every service wasn't applying this method in all the places it should have been. - Less coupling between the base classes since the Service was calling a method on the Issue.
This is inconsistent with all the other services and I suspect an unintentional oversight.
ryneeverett
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.