Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added filter option "only_if_reaction" for gitlab #963

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ForsakenNGS
Copy link

I want to use bugwarrior / taskwarrior to keep track of issues for open-source projects I am contributing (reports) or simply watching, which is quite difficult with the current implementation. Those issues are neither created by me, neither assigned to me and I (obviously) don't want to import all issues.

From my research the gitlab search parameter my_reaction_emoji is the best option for that. This way you can just thumbsup all issues that are relevant for you and have only those imported/updated.

@ryneeverett
Copy link
Collaborator

Great idea!

However, I don't think adding this configuration option is necessary. If I'm not mistaken you can achieve the same outcome with gitlab.issue_query = issues?state=opened&my_reaction_emoji=Any.

There's a maintenance cost for every configuration option we add and trying to ensure that all the options play nicely together becomes impossible. IMO we should ultimately deprecate all the filtering options in favor of user-specified query strings, but at the very least we should only add more filtering options due to popular demand or if it isn't possible to achieve the same outcome with the current configuration options.

However, I think the alternative to more options is better documentation of "recipes" such as this one. At the very least I'd like to see this added to the example in the "Custom query strings" section.

@ForsakenNGS
Copy link
Author

If I'm not mistaken you can achieve the same outcome with gitlab.issue_query = issues?state=opened&my_reaction_emoji=Any.

I was looking for such an option and didn't see it. If that's true I'll make a new pull request for adding the proper documentation ;-)

@ryneeverett ryneeverett marked this pull request as draft July 23, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants