Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locale sl-SI #78

Merged
merged 1 commit into from
Dec 31, 2021
Merged

Add locale sl-SI #78

merged 1 commit into from
Dec 31, 2021

Conversation

lauft
Copy link
Member

@lauft lauft commented Dec 10, 2021 •
edited
Loading

Add the locale sl-SI to holidata.

Before merging, the following has to be resolved:

  • Add official sources from the Government Gazette of the Republic of Slovenia for the holidays
  • Confirm correctness of the holiday names
  • Confirm that both, 01-01 and 01-02, are called novo leto (New Year's Day)
  • Confirm that all holidays exept 01-02 have not changed since 2011

Closes #77

@lauft lauft mentioned this pull request Dec 10, 2021
Closed
@lauft lauft added the locale label Dec 10, 2021
@lauft lauft added the help wanted Extra attention is needed label Dec 11, 2021
@dejande
Copy link

dejande commented Dec 21, 2021 •
edited
Loading

  • Confirm that both, 01-01 and 01-02, are called novo leto (New Year's Day)

They are

Confirm that all holidays exept 01-02 have not changed since 2011

  • 01-02 was removed in 2012 and than added back in in 2016 (work-free holiday)
  • 10-25 "dan suverenosti" was added in 2015 (non work-free holiday)
  • 09-23 "dan slovenskega športa" was added in 2020 (non work-free holiday)

@dejande
Copy link

dejande commented Dec 21, 2021

Add official sources from the Government Gazette of the Republic of Slovenia for the holidays

Answered in:
#77

@lauft
Copy link
Member Author

lauft commented Dec 30, 2021

@dejande I have updated the PR according to your feedback. I took the liberty to uniformly capitalize the first letter of each holiday name.

To me everything looks fine now, so I am going to prepare to create and release the data on holidata.net

@lauft
Add locale sl-SI
9216c22 
Closes #77
Closes #78

Signed-off-by: Thomas Lauf <thomas.lauf@tngtech.com>
@lauft lauft changed the title WIP: Add locale sl-SI Add locale sl-SI Dec 30, 2021
@lauft lauft merged commit 8481374 into master Dec 31, 2021
@lauft lauft deleted the locale/sl-SI branch December 31, 2021 11:24
@lauft
Copy link
Member Author

lauft commented Dec 31, 2021

Rebased and merged! Thanks for your contribution, @dejande.
Please report back if there are any changes to the holidays, so we can keep this locale up to date. ❤️

@lauft lauft mentioned this pull request Jan 12, 2022
Closed
@lauft lauft removed the help wanted Extra attention is needed label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
locale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add locale for sl-SI
2 participants
@lauft @dejande