Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add server-side config --snapshot-{days,versions} #295

Merged
merged 3 commits into from
Oct 10, 2021
Merged

Conversation

djmitche
Copy link
Collaborator

@djmitche djmitche commented Oct 9, 2021

This also increases the defaults from the previous hard-coded values.

@djmitche djmitche requested a review from dbr as a code owner October 9, 2021 13:58
@dbr
Copy link
Collaborator

dbr commented Oct 10, 2021

And of course the tests need fixing - seems like it's just missing a few Default::default()

@djmitche
Copy link
Collaborator Author

Rebased and defaults fixed. I also fixed up the TODO I left in there.

Copy link
Collaborator

@dbr dbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@djmitche djmitche merged commit f229715 into main Oct 10, 2021
@djmitche djmitche deleted the issue23-config branch October 10, 2021 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants