Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't fail when using non UTF-8 charset #69

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Don't fail when using non UTF-8 charset #69

wants to merge 1 commit into from

Conversation

mowgli
Copy link

@mowgli mowgli commented Nov 23, 2019

This patch fixes failure when using non UTF-8 charset.

@mowgli
Don't fail when using non UTF-8 charset
efb2139 
This patch fixes failure when using non UTF-8 charset.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 91.281% when pulling efb2139 on mowgli:develop into d3e12d1 on robgolding:develop.

@robgolding
Copy link
Collaborator

I don't think we can feasibly use locale.nl_langinfo (yet), because it's not available on all systems on Python 2.7—which we still support for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mowgli @coveralls @robgolding