RFC/RFT: implement taskserver behind SSL proxy #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this should explain why I was never able to put Any reasons why this has not been merged yet?? |
taskd expects to be able to terminate the mTLS session itself. You might be able to passively proxy it but you can't frontload it I don't think, without this PR. |
Note: this removes 'chunked' receive and associated buffer copies trading it for allocating whole receive buffer up front.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset allows to put taskserver behind an SSL reverse proxy (eg. stunnel or haproxy). Original client's address is passed using PROXY protocol described at [1]. Both versions of the protocol are supported, though binary (v2) is preferred.
[1] http://www.haproxy.org/download/1.8/doc/proxy-protocol.txt