Improve CommonMark compatibility #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example input: [With parens in the URL](http://en.wikipedia.org/wiki/WIMP_(computing))
Example: [URL wrapped in angle brackets](</url/>).
According to https://spec.commonmark.org/0.29/#code-spans : > If the resulting string both begins and ends with a space character, but does not consist entirely of space characters, a single space character is removed from the front and back. This allows you to include code that begins or ends with backtick characters, which must be separated by whitespace from the opening or closing backtick strings.
I could not find this in the markdown spec, but https://github.com/michelf/mdtest/blob/master/Markdown.mdtest/Literal%20quotes%20in%20titles.text includes it in the test suite and I actually prefer the implementation after this change.
``` - - - foo ``` did not work because the empty line was swallowed when parsing the ruler.
Otherwise ``` - foo - bar + baz ``` will become a nested list
``` - foo - bar + baz ``` is two lists (see https://spec.commonmark.org/0.29/#example-271)
* nesting did not work * ">" without following space was not recognized as blockquote Quoting https://spec.commonmark.org/0.29/#example-5: > Normally the > that begins a block quote may be followed optionally by a space, which is not considered part of the content.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I checked smu's output with https://github.com/michelf/mdtest and fixed some deviations from the expected output.
This includes #10