Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update old DeleteChar usage & perform browserify on npm install #25

Merged
merged 3 commits into from May 7, 2013

Conversation

jedi4ever
Copy link
Contributor

  • the first is a small fixup for deleteChar to deleteCharacter in char.js
  • second is npm to run browserify on npm install too (not only pre-publish), this allows one to use the repo as a git dependency in package.json

@Gottox Gottox merged commit fe24111 into Gottox:master May 7, 2013
@Gottox
Copy link
Owner

Gottox commented May 7, 2013

Merged, but reverted 7495e6f

@jedi4ever
Copy link
Contributor Author

I understand, but imagine my scenario.

I'm developing against my terminal.js gitrepo on a version that is not published.
When I put the git dependency in my package.json , and do a npm install in my other project the dists files will not get created as they are not 'published'.

Therefore running it on install makes sense, unless there is another way of handling this using my own git repo?

@Gottox
Copy link
Owner

Gottox commented May 7, 2013

Seems valid. When using a git repository in package.json, prepublish won't be triggered. That's really odd :/

Gottox added a commit that referenced this pull request May 7, 2013
@Gottox
Copy link
Owner

Gottox commented May 12, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants