Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App Header: Selected item on mobile is not highlighted #1792

Closed
pomeras opened this issue Apr 22, 2024 · 6 comments · Fixed by #1843
Closed

App Header: Selected item on mobile is not highlighted #1792

pomeras opened this issue Apr 22, 2024 · 6 comments · Fixed by #1843
Assignees
@vanessatran-ddi
Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.

Comments

@pomeras
Copy link

pomeras commented Apr 22, 2024 •
edited
Loading

Describe the bug

Selected item in goa-app-header in mobile is not highlighted as can be seen in the attachment. The a link with class current is highlighted on desktop, but not on mobile.
image

Provide Code

No response

To Reproduce

goa-app-header with multiple items in mobile has no indication what item is selected.

Relevant console log output

No response

What browsers are you seeing the problem on?

No response

Additional context

No response
@pomeras pomeras added the Bug Something isn't working label Apr 22, 2024
@ArakTaiRoth ArakTaiRoth mentioned this issue Apr 25, 2024
Closed
@vanessatran-ddi vanessatran-ddi self-assigned this May 8, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 9, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
3631aa4 
…lighted
@vanessatran-ddi vanessatran-ddi mentioned this issue May 9, 2024
Merged
7 tasks
@vanessatran-ddi vanessatran-ddi linked a pull request May 9, 2024 that will close this issue
fix(#1368,#1792,#1772,#1569): fixing link active when router change #1843
Merged
7 tasks
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 9, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
a396d21 
…lighted
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 14, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
c3b0ce7 
…lighted
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 14, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
81212e3 
…lighted
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 17, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
50af581 
…lighted
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 22, 2024
@vanessatran-ddi
fix(GovAlta#1792): selected item in goa-app-header in mobile not high…
3a465f7 
…lighted
@ArakTaiRoth ArakTaiRoth changed the title [Bug]: Selected item in goa-app-header in mobile is not highlighted App Header: Selected item on mobile is not highlighted May 28, 2024
ArakTaiRoth pushed a commit that referenced this issue May 29, 2024
@vanessatran-ddi @ArakTaiRoth
fix(#1792): selected item in goa-app-header in mobile not highlighted
8766dae
@tzuge
Copy link
Collaborator

tzuge commented May 29, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.56 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label May 29, 2024
@tzuge
Copy link
Collaborator

tzuge commented May 30, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jun 11, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 4.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vanessatran-ddi vanessatran-ddi

Labels
Bug Something isn't working released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#1368,#1792,#1772,#1569): fixing link active when router change vanessatran-ddi/ui-components
3 participants
@pomeras @tzuge @vanessatran-ddi