Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Item - error and helpertext converted to slots #1814

Closed
Spark450 opened this issue Apr 29, 2024 · 8 comments · Fixed by #1853, GovAlta/ui-components-docs#164 or #1889
Closed

Form Item - error and helpertext converted to slots #1814

Spark450 opened this issue Apr 29, 2024 · 8 comments · Fixed by #1853, GovAlta/ui-components-docs#164 or #1889
Assignees
@syedszeeshan
Labels
Enhancement New feature or request released on @alpha Released into alpha. released Released into production.

Comments

@Spark450
Copy link
Collaborator

Spark450 commented Apr 29, 2024 •
edited by ArakTaiRoth
Loading

Background:

-The use of italics is the GOA standard when referencing the names of legislation

  • In order to meet this standard we need to change our support of italics in the form item.

Acceptance Criteria:

  • error and helpertext properties also allow slot content
  • Update the component documentation to mark properties as slots and make an example of this usage
  • Defaults should continue to be "normal" for the form item.
Screen Shot 2024-04-26 at 1 49 19 PM
@Spark450 Spark450 added the Enhancement New feature or request label Apr 29, 2024
@ArakTaiRoth ArakTaiRoth changed the title "Italics" and "bolding" for label, error, and helper text of the "form item" component "Italics" and "bolding" for error, and helper text of the "form item" component May 9, 2024
@ArakTaiRoth ArakTaiRoth changed the title "Italics" and "bolding" for error, and helper text of the "form item" component Form Item - error and helpertext converted to slots May 9, 2024
@syedszeeshan syedszeeshan self-assigned this May 15, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 21, 2024
@syedszeeshan
fix(GovAlta#1814): form item slotted error and helptext
4577ef2
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 21, 2024
@syedszeeshan
fix(GovAlta#1814): form item slotted error and helptext
e4b4561
This was linked to pull requests May 21, 2024
fix(#1814): allow form-item slotted content for helptext and error #1853
Merged
fix(#1814): form item slotted error and helptext documentation GovAlta/ui-components-docs#164
Merged
@ArakTaiRoth ArakTaiRoth removed a link to a pull request May 21, 2024
fix(#1814): form item slotted error and helptext documentation GovAlta/ui-components-docs#164
Merged
@ArakTaiRoth ArakTaiRoth linked a pull request May 21, 2024 that will close this issue
fix(#1814): form item slotted error and helptext documentation GovAlta/ui-components-docs#164
Merged
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 24, 2024
@syedszeeshan
fix(GovAlta#1814): FormItem - slotted error and helptext
9d5022a
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 27, 2024
@syedszeeshan
fix(GovAlta#1814): FormItem-UI-slotted-error-helptext-ReactNode
205553b
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 27, 2024
@syedszeeshan
fix(GovAlta#1814): FormItem-UI-slotted-error-helptext-ReactNode
2cc9ce9
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 28, 2024
@syedszeeshan
fix(GovAlta#1814): allow form-item slotted content for helptext and e…
62690ea 
…rror
ArakTaiRoth pushed a commit that referenced this issue May 28, 2024
@syedszeeshan @ArakTaiRoth
fix(#1814): allow form-item slotted content for helptext and error
fff94a7
@tzuge
Copy link
Collaborator

tzuge commented May 28, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.54 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented May 28, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.27 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label May 28, 2024
syedszeeshan added a commit to syedszeeshan/ui-components that referenced this issue May 29, 2024
@syedszeeshan
fix(GovAlta#1814): allow form-item slotted content for helptext and e…
104d440 
…rror
ArakTaiRoth pushed a commit that referenced this issue May 30, 2024
@syedszeeshan @ArakTaiRoth
fix(#1814): allow form-item slotted content for helptext and error
48a1c45
@tzuge
Copy link
Collaborator

tzuge commented May 30, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.28 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 4, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.57 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ArakTaiRoth ArakTaiRoth mentioned this issue Jun 5, 2024
Merged
@ArakTaiRoth ArakTaiRoth linked a pull request Jun 5, 2024 that will close this issue
fix(#1887): Reverting error and helptext type change #1889
Merged
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jun 11, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 4.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syedszeeshan syedszeeshan

Labels
Enhancement New feature or request released on @alpha Released into alpha. released Released into production.
Projects
Design System Backlog
Status: Alpha
Milestone
No milestone
3 participants
@tzuge @syedszeeshan @Spark450