Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion and Detail: When expanded the body content isn't read by screen readers #1868

Closed
ArakTaiRoth opened this issue May 23, 2024 · 6 comments · Fixed by #1877
Closed
Assignees
Labels
Bug Something isn't working Critical For stories that need to be worked on immediately, to the exclusion of everything else released on @alpha Released into alpha. released Released into production.

Comments

@ArakTaiRoth
Copy link
Collaborator

ArakTaiRoth commented May 23, 2024

Info

A screen reader will happily read the heading property and anything in the headingcontent slot. It will also read the status of the accordion, open or closed. However, when an Accordion is opened, the body content is not read at all.

Acceptance Criteria:

  1. Body content in an accordion and detail components should be read by a screen reader when the Accordion is expanded

More Info

Current working theory is to apply aria-expanded to the content div and set it to true or false based on the open and closed state.

@ArakTaiRoth ArakTaiRoth added Bug Something isn't working Critical For stories that need to be worked on immediately, to the exclusion of everything else labels May 23, 2024
@ArakTaiRoth ArakTaiRoth changed the title Accordion: When expanded the body content isn't read by screen readers Accordion and Detail: When expanded the body content isn't read by screen readers May 24, 2024
@vanessatran-ddi vanessatran-ddi self-assigned this May 24, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 30, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue May 30, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Jun 6, 2024
vanessatran-ddi added a commit to vanessatran-ddi/ui-components that referenced this issue Jun 10, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 10, 2024

🎉 This issue has been resolved in version 1.17.0-alpha.65 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released on @alpha Released into alpha. label Jun 10, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge tzuge added the released Released into production. label Jun 11, 2024
@tzuge
Copy link
Collaborator

tzuge commented Jun 11, 2024

🎉 This issue has been resolved in version 4.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 15, 2024

🎉 This issue has been resolved in version 4.17.0-alpha.31 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.0-alpha.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@tzuge
Copy link
Collaborator

tzuge commented Jun 27, 2024

🎉 This issue has been resolved in version 3.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Critical For stories that need to be worked on immediately, to the exclusion of everything else released on @alpha Released into alpha. released Released into production.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants