Add rudimentary SASS integration. #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,7 @@ | |||
| .env | |||
| *.pyc | |||
| app/config/local_config.yml | |||
| app/static/css | |||
There was a problem hiding this comment.
This is where our generated SASS goes... It's confusing right now because we also have hand-written CSS in app/static/styles, but once we've fully moved over to claudio's CSS, I assume we'll get rid of that.
talos
added a commit
that referenced
this pull request
Oct 2, 2015
Add rudimentary SASS integration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @claudioccm's CSS is SASS-based, it'd be really nice if we could have the source SASS in this repository and easily iterate on it from here.
This PR adds libsass-python to our
appcontainer and integrates SASS into our build process.For development, we use SASS middleware that regenerates the SASS on each request and gives us handy error feedback in our views like this:
For production, I've added
manage.py build_sass, which is executed as part ofrun.sh, so that our compiled SASS is served as static CSS in production.We also compile our SASS as part of our test suite to make sure it's always syntactically correct.