Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with overlay module #5

Open
jlyon opened this issue May 17, 2016 · 6 comments
Open

Compatibility with overlay module #5

jlyon opened this issue May 17, 2016 · 6 comments
Assignees
Labels

Comments

@jlyon
Copy link
Contributor

jlyon commented May 17, 2016

Overlay sucks, but it's part of the Standard installation in D7.

There is currently an issue with hasbangs collisions, so none of the Govready Dashboard endpoints work in an Overlay modal.

@aschmoe
Copy link
Contributor

aschmoe commented Jul 26, 2016

@jlyon looked into this a little more and the # is hardcoded as the URL identifier in the hashHistory https://github.com/ReactTraining/history. As this is what react-router depends on not sure exactly what our options are.

@gregelin
Copy link

@jlyon @aschmoe can you describe more what the issue is?

Is it possible to use/support a different framework than React?

@jlyon
Copy link
Contributor Author

jlyon commented Aug 2, 2016

Near term: Warn of conflict when plugin is enabled/when someone goes to dashboard

@aschmoe
Copy link
Contributor

aschmoe commented Aug 2, 2016

for Alex's research https://auth0.com/blog/react-router-alternatives/

@jlyon
Copy link
Contributor Author

jlyon commented Aug 9, 2016

Warning message addressed in #35.

@aschmoe It looks like the react routes are actually working within the overlay, it just reloads the page everytime (which isn't ideal, but obviously still works).

@jlyon
Copy link
Contributor Author

jlyon commented Aug 9, 2016

Moving this issue back to the backlog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants