Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development #8

Merged
merged 5 commits into from Dec 11, 2018
Merged

Development #8

merged 5 commits into from Dec 11, 2018

Conversation

kelvinwijaya
Copy link
Contributor

Description

Enhance Travis CI configuration to run unit testing

Fixes #7

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit testing through nunit and integrate with CI pipeline

robincher
robincher suggested changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@robincher robincher left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To items need to be done before this PR can be merged

  1. Update the change log
  2. Update gitignore to exclude the temp folder where test data are pulled

@kelvinwijaya
Copy link
Contributor Author

Updated as per review, thanks

@kelvinwijaya kelvinwijaya merged commit 964b62c into master Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robincher robincher robincher approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Travis CI configuration to run unit testing
2 participants
@kelvinwijaya @robincher