✨ improvements + TypeScript Types #50
Conversation
There was a problem hiding this comment.
@harshzalavadiya thank you! I have just few questions, please see my comments
README.md
Outdated
| [](https://github.com/Gozala/querystring/actions) | ||
| [](https://github.com/Gozala/querystring/actions) |
There was a problem hiding this comment.
I think this belongs to PR which configures the actions (?)
There was a problem hiding this comment.
Yes this was supposed to be in GitHub Actions branch but since Readmd.md is changed to README.md in this one I thought of adding it here so there can be minimal diff, so first CI branch needs to get merged I guess
There was a problem hiding this comment.
Ok, let's put this one on hold then for now
index.d.ts
Outdated
| @@ -0,0 +1,17 @@ | |||
| type decodeFuncType = ( | |||
There was a problem hiding this comment.
Project exports three modules. Will querystring/encode and querystring/decode be also covered with this typings?
There was a problem hiding this comment.
It wasn't earlier but I have made change to accomodate that
| @@ -0,0 +1,20 @@ | |||
| /** | |||
There was a problem hiding this comment.
Is there a way to keep typings in e.g. typings folder?
It'll be great to not mix them with regular modules (same as e.g. we keep tests in test folder) ?
There was a problem hiding this comment.
I tried doing that, by specifying "typings" flag in package.json but seems it's not working also we have seprate file based import as well
There was a problem hiding this comment.
also we have separate file based import as well
What exactly do you mean by that?
There was a problem hiding this comment.
means you can use same function multiple ways
import qs from "querystring"
import encode from "querystring/encode"There was a problem hiding this comment.
Indeed, there's seems no way to keep then in dedicated dir. It's a pity, anyway let's go with this
CHANGELOG.md
Outdated
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [0.2.1] - 2021-01-02 |
There was a problem hiding this comment.
Let's remove release notes for new version (I think it's nice to have releases not mixed with PR's that address different concerns)
| @@ -0,0 +1,20 @@ | |||
| /** | |||
There was a problem hiding this comment.
Indeed, there's seems no way to keep then in dedicated dir. It's a pity, anyway let's go with this
Split from #46
Changelog
.gitignoreHistory.mdtoCHANGELOG.md