Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add windows support by updating dependency #157

Merged
merged 2 commits into from Aug 19, 2021
Merged

add windows support by updating dependency #157

merged 2 commits into from Aug 19, 2021

Conversation

fcakyon
Copy link
Contributor

@fcakyon fcakyon commented Aug 16, 2021

@mmeendez8 @igonro @cgiraldo thanks a lot for this awesome package!

pycocotools-fix package currently doesnt work on windows: junjuew/cocoapi#4

official pycocotools package is constantly updated by the facebook research team: https://pypi.org/project/pycocotools/

by accepting this pr, pyodi package will be supported on windows.

@mmeendez8 mmeendez8 self-requested a review August 17, 2021 07:34
@mmeendez8
Copy link
Contributor

Hi @fcakyon!

Thanks for your PR :) I am gonna add a CI build to test pyodi installation on windows and merge this if everything works properly!

@mmeendez8 mmeendez8 mentioned this pull request Aug 17, 2021
@mmeendez8
Copy link
Contributor

I can see build is crashing with pycocotools-fix https://github.com/Gradiant/pyodi/runs/3348162090

Could you merge your branch with master to use latest workflow so we can check if everything works as expected?

@fcakyon
Copy link
Contributor Author

fcakyon commented Aug 17, 2021

@mmeendez8 you mean i should merge in my own fork?

@mmeendez8
Copy link
Contributor

@mmeendez8 you mean i should merge in my own fork?

Yes, this is a bit annoying https://github.community/t/updating-workflow-file-on-master-and-rerunning-an-action-still-shows-old-workflow-file/18507/10

You can merge your local branch with master and push, that should trigger the latest changes in the workflow

@mmeendez8
Copy link
Contributor

@fcakyon I just merged it for you! Thanks again for this :)

@mmeendez8 mmeendez8 merged commit 28f0b24 into Gradiant:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants