Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix windows build #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix windows build #4

wants to merge 2 commits into from

Conversation

fcakyon
Copy link

@fcakyon fcakyon commented Feb 13, 2021

  • currently, this package cannot be instlalled on windows due to gcc flags in setup.py
  • this pr fixes this bug so that the package can be installed on windows
  • refer to this commit

@junjuew
Copy link
Owner

junjuew commented Feb 21, 2021

Would this change break installation on Linux?

@fcakyon
Copy link
Author

fcakyon commented Feb 21, 2021 •
edited

@junjuew No it doesnt affect linux installation. It will make this package cross platform.

You can try it yourself on linux by: pip install git+git://github.com/fcakyon/cocoapi-fix.git#subdirectory=PythonAPI

@fcakyon
Copy link
Author

fcakyon commented Apr 6, 2021

@junjuew would you mind accepting the pr and release a new version on pypi?

@fcakyon fcakyon mentioned this pull request Aug 16, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@fcakyon @junjuew