Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to compile builds without flatpak #118

Merged
merged 4 commits into from Aug 13, 2022
Merged

Conversation

tfuxu
Copy link
Member

@tfuxu tfuxu commented Aug 12, 2022

This PR provides a way for developers and distro packagers to compile and ship AdwCustomizer without a need to install flatpak.

Btw, where can I find a source code for material_color_utilities_python library? I couldn't find it on PyPI, and I would be interested to maybe improve it, as its speed for now is atrocious. Never mind, I found it on yours organization profile.

Copy link
Contributor

@GradienceBot GradienceBot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome on Adwaita Manager. 🥳 We really appreciate your pull request. The core team will review your issue as soon as possible.

@0xMRTT
Copy link
Member

0xMRTT commented Aug 12, 2022

Hi @tfuxu.

material_color_utilities_python is a port in python of the original one in JavaScript. It's forked from the repo of his creator in AdwCustomizerTeam/material_color_utilities_python.

The problem with the slow is know. It's a goal for the next version.

Currently, I shipped material_color_utilities_python as python package .whl

I need to change the meson architecture for allowing more flexibility (eg using variables for app ID, project name).

For shipping material_color_utilities_python there is two solutions:

  • publish on pypi
  • include as meson subproject

@0xMRTT
Copy link
Member

0xMRTT commented Aug 12, 2022

Your changes on the README are very useful. Thanks.

Do you want to improve the material color utilities?

@tfuxu
Copy link
Member Author

tfuxu commented Aug 12, 2022

Hi @tfuxu.

material_color_utilities_python is a port in python of the original one in JavaScript. It's forked from the repo of his creator in AdwCustomizerTeam/material_color_utilities_python.

The problem with the slow is know. It's a goal for the next version.

Currently, I shipped material_color_utilities_python as python package .whl

I need to change the meson architecture for allowing more flexibility (eg using variables for app ID, project name).

For shipping material_color_utilities_python there is two solutions:

* publish on pypi

* include as meson subproject

Thanks for reply,
Good to know you guys are working on this problem. I think that including it as a subproject would be the best solution, so that your fork wouldn't collide with original creator's library if he would want to put it on PyPI later on.

@tfuxu
Copy link
Member Author

tfuxu commented Aug 12, 2022

Your changes on the README are very useful. Thanks.

Do you want to improve the material color utilities?

I would have to check it out first, but maybe I could help improve it later.

@0xMRTT
Copy link
Member

0xMRTT commented Aug 12, 2022

You are welcome 🙂.

Reworking the meson architecture is a priority. Thanks 🙏👍 for providing this script.

@0xMRTT 0xMRTT changed the base branch from next to main August 13, 2022 12:47
@0xMRTT 0xMRTT enabled auto-merge August 13, 2022 12:47
@0xMRTT 0xMRTT disabled auto-merge August 13, 2022 12:50
Signed-off-by: tfuxu <73042332+tfuxu@users.noreply.github.com>
@tfuxu
Copy link
Member Author

tfuxu commented Aug 13, 2022

@0xMRTT
Okay, I've fixed conflicts, should be ready to merge :)

@0xMRTT 0xMRTT merged commit dd1064d into GradienceTeam:main Aug 13, 2022
@LyesSaadi
Copy link
Member

Hello !

Good to know you guys are working on this problem. I think that including it as a subproject would be the best solution, so that your fork wouldn't collide with original creator's library if he would want to put it on PyPI later on.

Please don't. I'm interested in maybe packaging this for Fedora. A subproject, or even two concurrent versions of the same library, would be quite difficult to manage. Wouldn't it be possible to either submit your changes to upstream or to see with the original creator if he wishes to push his project to pypi or even to change the canonical project to your fork?

I know this isn't the best place to discuss this, but, unfortunately, the issue tracker in GradienceTeam/material-color-utilities-python is closed.

@0xMRTT
Copy link
Member

0xMRTT commented Aug 17, 2022

I've enabled the issue tracker in the repo

@0xMRTT
Copy link
Member

0xMRTT commented Aug 17, 2022

I've submitted a PR but nothing happened

@LyesSaadi
Copy link
Member

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants