Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring meson architecture #121

Merged
merged 4 commits into from Aug 13, 2022
Merged

Conversation

tfuxu
Copy link
Member

@tfuxu tfuxu commented Aug 13, 2022

This PR mostly makes meson structure in this codebase more readable by adding new constants, and by moving some parts of src/meson.build to a more central meson.build.

Changes:

  • Create new constants in info.py.in: rootdir and app_id,
  • Remove (where possible) redundancy and switch to new constants,
  • Move some parts of src/meson.build to more central meson.build,
  • Add new if statement that checks if the host has a python3 binary available,
  • Rename info.py.in to constants.py.in,
  • In src/window.py, add new if statement that adds devel CSS class to a window if build_type is set to "debug".

@0xMRTT
Copy link
Member

0xMRTT commented Aug 13, 2022

Hi @tfuxu

Thanks you 😎 for the PR. It's exactly what I wanted to do.

@0xMRTT 0xMRTT changed the base branch from next to main August 13, 2022 12:46
@0xMRTT 0xMRTT enabled auto-merge August 13, 2022 12:46
@0xMRTT 0xMRTT disabled auto-merge August 13, 2022 12:49
@0xMRTT 0xMRTT merged commit fd010a8 into GradienceTeam:main Aug 13, 2022
@0xMRTT
Copy link
Member

0xMRTT commented Aug 20, 2022

@all-contributors please add @tfuxu for code

@allcontributors
Copy link
Contributor

@0xMRTT

I've put up a pull request to add @tfuxu! 🎉

@tfuxu tfuxu deleted the meson-refactor branch September 10, 2022 20:38
@daudix daudix mentioned this pull request Oct 4, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants