Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create preferences window #311

Merged
merged 8 commits into from Sep 1, 2022
Merged

Create preferences window #311

merged 8 commits into from Sep 1, 2022

Conversation

tfuxu
Copy link
Member

@tfuxu tfuxu commented Aug 31, 2022

This PR adds a preferences window with options for setting overrides in Flatpak aplications.
These changes have, to some extent, features requested in issue #276.

Changes

  • Create new .blp file for preferences window,
  • Make self.settings object accessible to other files,
  • Create new item in main-menu menu: Preferences

I'm setting this PR as a draft for now, to check if everything works as expected

Ps. This time, I didn't forget to update POTFILES :P

* open self.settings object to other files
* create new item in main-menu menu: Preferences
@0xMRTT
Copy link
Member

0xMRTT commented Sep 1, 2022

Also, the ability to configure Flatpak will' go in the welcome dialog too.

@tfuxu
Copy link
Member Author

tfuxu commented Sep 1, 2022

Also, the ability to configure Flatpak will' go in the welcome dialog too.

Yes, I saw that you started working on it. I could maybe move functions from preferences.py as a module, just so there won't be two implementations of the same feature in different parts of code.

@0xMRTT
Copy link
Member

0xMRTT commented Sep 1, 2022

Yes 👍

@tfuxu
Copy link
Member Author

tfuxu commented Sep 1, 2022

Okay, should be ready for review. I've also added support for gtk3 in functions, so the same functions can be used without need for creating additional changes.

@tfuxu tfuxu marked this pull request as ready for review September 1, 2022 16:17
@0xMRTT 0xMRTT merged commit b029dc1 into GradienceTeam:main Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants