Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change url routes to remove pk #152

Merged
merged 1 commit into from
Jun 15, 2021
Merged

Change url routes to remove pk #152

merged 1 commit into from
Jun 15, 2021

Conversation

itsthejoker
Copy link
Member

Relevant issue: N/A

Description:

When I set up the routes for the posts on the website, I used pk+slug (1-our-story) so that we could have multiple posts with the same name and still tell them apart. That's a great idea as long as the primary key doesn't change, and for some reason it is and the PK of our donations page keeps changing and invalidating its own URL. This PR:

  • swaps over to slug only routes
  • provides a compatibility redirect layer for the routes we've already publicized -- can be removed after we forget why we added it

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

@itsthejoker itsthejoker requested a review from a team as a code owner June 15, 2021 04:56
@MaxVanDeursen
Copy link
Member

We have to make sure that we find out why these PKs are changing though; that does not sound like a feature we want.

@itsthejoker itsthejoker merged commit e476b41 into master Jun 15, 2021
@itsthejoker itsthejoker deleted the fix-post-routing branch June 15, 2021 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants