Remove submissions on report #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJentzsch
approved these changes
Dec 29, 2021
Comment on lines
-487
to
-489
| if request.GET.get("reason") is None: | ||
| # they just wanted to return the post. No reason to investigate. | ||
| return |
There was a problem hiding this comment.
Why is this removed?
If they just want a different pot we shouldn't get a message on Slack
There was a problem hiding this comment.
Ah nevermind, I see it now. I suppose we don't need to construct the Slack blocks in that case, but it should be fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #258
Description:
Something that was brought up in Discord is that reported posts stay in the queue, and because we're not tied to Reddit anymore, we can remove these now as they come in and avoid the unfortunate situation that happened earlier with a volunteer reporting a post and then rerolling it multiple times. This PR reworks the logic of the report flow to automatically remove a post pending the response from the Slack ping, which can optionally reinstate it. Also includes some very small fixes I noticed while debugging this.
Checklist: