Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider recent transcriptions for check percentage #306

Merged
merged 5 commits into from
Jan 10, 2022

Conversation

TimJentzsch
Copy link
Contributor

@TimJentzsch TimJentzsch commented Jan 7, 2022

Relevant issue: Closes #305

Description:

If a transcriber had a long pause and is just returning to transcribing, they should be checked again.
If they did less than 5 transcriptions in the past month, they are now guaranteed to be checked.
Otherwise, the normal system is used.

This PR also factors out some static methods out of the SubmissionViewSet and turns them into functions.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

If a transcriber had a long pause and is just returning to transcribing, they should be checked again.
If they did less than 5 transcriptions in the past month, they are guaranteed to be checked.
@TimJentzsch TimJentzsch marked this pull request as ready for review January 7, 2022 17:31
@TimJentzsch TimJentzsch requested a review from a team as a code owner January 7, 2022 17:31
Copy link
Member

@itsthejoker itsthejoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I admit that I can't give this a thorough review, but it looks good to me and the tests pass, so let's ship it 🚀

@TimJentzsch TimJentzsch merged commit a474bcd into master Jan 10, 2022
@TimJentzsch TimJentzsch deleted the 305-check-returning-transcribers branch January 10, 2022 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Consider recent transcription count for check percentage
2 participants