Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /submission/approve endpoint #348

Merged
merged 6 commits into from
Jan 29, 2022
Merged

Add /submission/approve endpoint #348

merged 6 commits into from
Jan 29, 2022

Conversation

TimJentzsch
Copy link
Contributor

@TimJentzsch TimJentzsch commented Jan 29, 2022

Relevant issue: Closes #345

Description:

We can now model the approval of submissions. This will allow us to sync approve actions on Reddit to Blossom.

  • Add approved field to the Submission model to indicate whether a submission has been approved by a moderator.
  • Add /submission/approve endpoint to allow clients (e.g. tor_archivist) to approve a submission (or revert the approval).
  • Don't generate report messages for approved submissions.
  • Set the approved field when processing the actions on Slack report messages.
  • Change the response of /submission/remove from 201 to 200 (because we don't actually create anything).

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

@TimJentzsch TimJentzsch requested a review from a team as a code owner January 29, 2022 17:01
@itsthejoker
Copy link
Member

Is the response change going to need updates to the wrapper?

@TimJentzsch
Copy link
Contributor Author

I don't think this method has been included in the wrapper in the first place, we called that manually

@TimJentzsch TimJentzsch merged commit a7f5473 into master Jan 29, 2022
@TimJentzsch TimJentzsch deleted the 345-approve-endpoint branch January 29, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add /submission/approve endpoint
2 participants