Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transcription link not being picked up correctly #362

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

TimJentzsch
Copy link
Contributor

Relevant issue: Closes #361

Description:

The OCR transcription got picked up instead of the user provided transcription.
It doesn't have a link, so [Removed] was displayed in the check message instead.

We now filter the transcription author to make sure that the correct one is selected.

Additionally this adds a Γ character to the user gamma in the check message.

Checklist:

  • Code Quality
  • Pep-8
  • Tests (if applicable)
  • Success Criteria Met
  • Inline Documentation
  • Wiki Documentation (if applicable)

The OCR transcription got picked up instead of the user provided transcription.
It doesn't have a link, so [Removed] was displayed in the check message instead.
@TimJentzsch TimJentzsch requested a review from a team as a code owner February 22, 2022 23:10
@TimJentzsch TimJentzsch merged commit a99b207 into master Feb 22, 2022
@TimJentzsch TimJentzsch deleted the 361-fix-transcription-check-links branch February 22, 2022 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix transcription link in transcription check messages
1 participant