Update migration command #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimJentzsch
reviewed
Jul 20, 2022
Comment on lines
+456
to
+459
| transcriptions = Transcription.objects.filter( | ||
| submission__in=existing_submissions, author=self.old_user | ||
| ) | ||
| transcriptions.update(author=self.new_user) |
There was a problem hiding this comment.
Is the submission__in check necessary here? I think we want to just migrate all transcriptions, so we could just migrate all of them.
Or does that not work with the revert?
There was a problem hiding this comment.
Because we keep track of the submissions we act on (for revert purposes) it makes more sense to only modify the transcriptions attached to the submissions we're tracking so that we don't overreach. I agree that in most cases it'll be everything attached to the user, but I can't guarantee that.
TimJentzsch
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: #165
Description:
Modifies transcriptions along with submissions. To properly run this, we will need to take the accounts that have already been migrated and run the following:
This will update all of the transcriptions for the affected accounts and attribute them to the new account.
Checklist: