Packaging! #434
Merged
Packaging! #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This is a ridiculously large PR. I highly recommend just checking it out locally to see the changes in your IDE because it's impossible to view online. I also guarantee I missed something but everything runs locally as far as I can tell. We will need to test this pretty hard to make sure everything works.
Short version: this moves all the apps under
blossom/, fixes all the broken tests, and IN THEORY has everything needed to actually package the entirety of blossom as a single binary. (Amusingly, it's much smaller than Buttercup -- 36MB to 95MB.)Besides that, it also adds a new workflow that builds the zipapp and runs the selfcheck command as part of the PR checks -- this is complex enough that it seemed like a good idea. If this works then I'll backport it to the others.
Checklist: