Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify PR template to stuff we actually need #479

Merged
merged 2 commits into from
May 12, 2023

Conversation

TimJentzsch
Copy link
Contributor

Relevant issue: N/A

Description:

Greatly simplify the PR template to stuff we actually need.

  • Screenshots: Don't really make sense for Blossom
  • Testing Instructions: Pretty much always poetry run pytest
  • Checklist: Mostly checked by CI anyways

@TimJentzsch TimJentzsch requested a review from a team as a code owner May 10, 2023 10:08
@itsthejoker
Copy link
Member

I'm cool with stripping out most of it, but I would like to keep the checklist (though it can totally be modified). It's not a functional checklist, but a mental one -- if you look at it and there's a checkbox for X, I want folks to look at it and say "ah fuck I forgot to do X", ya know? Open to what fields to include in it, though.

@TimJentzsch
Copy link
Contributor Author

Sure, I'm fine with that.
Which parts would you like to keep?
Maybe this?

  • Code Quality
  • Inline comments
  • Tests

@itsthejoker
Copy link
Member

@TimJentzsch Yeah, that works for me 👍

@itsthejoker itsthejoker merged commit 092fc2b into master May 12, 2023
3 checks passed
@itsthejoker itsthejoker deleted the simplify-pr-template branch May 12, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants