Switch from flake8 and isort to ruff #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue: N/A
Description:
This PR replaces the linting from flake8 and isort with ruff.
This improves the lint time from 8.74s to 0.03s on my machine.
I chose the Ruff config such that there are as little formatting changes in this PR as possible.
In the future, we probably want to re-enable some of the disabled rules and fix the corresponding errors.
I also vote to increase the maximum line length for Ruff and Black to at least 100 (and then enable the Ruff lint rule for that).
This PR also fixes the Toml entry for dev dependencies as the naming has been changed for poetry.