Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Make linting consistent with blossom #370

Merged
merged 14 commits into from
May 25, 2023
Merged

Make linting consistent with blossom #370

merged 14 commits into from
May 25, 2023

Conversation

TimJentzsch
Copy link
Contributor

@TimJentzsch TimJentzsch commented May 17, 2023

This PR ports over the linting setup from Blossom to ToR, to have a consistent setup across all our repositories.

  • Add ruff linter and configuration
  • Fix lint errors
  • Add pre-commit hook configuration

@TimJentzsch TimJentzsch requested a review from a team as a code owner May 17, 2023 12:48
@TimJentzsch TimJentzsch marked this pull request as draft May 17, 2023 12:48
@itsthejoker
Copy link
Member

Pytz is deprecated - we'll need to use zoneinfo instead. https://docs.python.org/3/library/zoneinfo.html

@TimJentzsch
Copy link
Contributor Author

Pytz is deprecated - we'll need to use zoneinfo instead. https://docs.python.org/3/library/zoneinfo.html

Nice, didn't know this was a built-in thing!
I ended up using datetime.timezone.utc which is a nice replacement.
I'll open up an issue to migrate for blossom and buttercup as well.

@itsthejoker
Copy link
Member

And I didn't know that datetime.timezone.utc was a thing! 🎉

@TimJentzsch TimJentzsch marked this pull request as ready for review May 25, 2023 08:43
tor/core/users.py Outdated Show resolved Hide resolved
itsthejoker
itsthejoker previously approved these changes May 25, 2023
@TimJentzsch TimJentzsch merged commit 02a6d59 into main May 25, 2023
3 checks passed
@TimJentzsch TimJentzsch deleted the switch-to-ruff branch May 25, 2023 14:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants