Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use inspect.Signature instead of inspect.formatargspec #203

Closed
wants to merge 2 commits into from
Closed

Use inspect.Signature instead of inspect.formatargspec #203

wants to merge 2 commits into from

Conversation

grayjk
Copy link

@grayjk grayjk commented Jan 7, 2022

Closes #196

@GrahamDumpleton
Copy link
Owner

This needs to either wait until Python 2.7 support is dropped, or be changed to still accomodate that version.

Traceback (most recent call last):
  File "setup.py", line 42, in <module>
    ext_modules=[] if disable_extensions else extensions
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/__init__.py", line 162, in setup
    return distutils.core.setup(**attrs)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/distutils/core.py", line 124, in setup
    dist.parse_config_files()
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/dist.py", line 702, in parse_config_files
    ignore_option_errors=ignore_option_errors)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 121, in parse_configuration
    meta.parse()
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 426, in parse
    section_parser_method(section_options)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 399, in parse_section
    self[name] = value
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 184, in __setitem__
    value = parser(value)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 515, in _parse_version
    version = self._parse_attr(value, self.package_dir)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/site-packages/setuptools/config.py", line 349, in _parse_attr
    module = import_module(module_name)
  File "/opt/hostedtoolcache/Python/2.7.18/x64/lib/python2.7/importlib/__init__.py", line 37, in import_module
    __import__(name)
  File "/home/runner/work/wrapt/wrapt/src/wrapt/__init__.py", line 10, in <module>
    from .decorators import (adapter_factory, AdapterFactory, decorator,
  File "/home/runner/work/wrapt/wrapt/src/wrapt/decorators.py", line 34, in <module>
    from inspect import ismethod, isclass, Signature, Parameter
ImportError: cannot import name Signature

@grayjk
Copy link
Author

grayjk commented Jan 10, 2022

Have you identified a timeline for removing python 2 support? How does that align with a Python 3.11 release in October 2022?

simcax added a commit to simcax/dotime that referenced this pull request Jan 14, 2022
Until wrapt issue with python 3.11 is resolved (GrahamDumpleton/wrapt#203) and merged, we will go with Python 3.10
@GrahamDumpleton
Copy link
Owner

Python 2 support would be dropped when get around to going through:

and try and switch to Python stable API.

Don't know when that may be.

@GrahamDumpleton
Copy link
Owner

Should have been dealt with by #205

@grayjk grayjk deleted the issue-196 branch March 5, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.11: ImportError: cannot import name 'formatargspec' from 'inspect'
2 participants