Extra error: "The ODF does not match the combination file"

[oleg68]

When I try to import a combination saved from a previous version of ODF, the combination is loaded successfully, but the error message "The ODF does not match the combination file" appears in the log window.

1. I import a combination into the organ, not the organ into the combination. So this message is not precise. The combination file does not match the current ODF sounds more precisely.
2. Because the combination is loaded anyway, the message should be a warning, not an error.

[larspalo]

I think we absolutely should change that message! Also related to #807 is the fact that if the ChurchName differs, you first get a log message warning This combination file is only compatible with:, that I suggest we alter to This settings file was originally made for: and then you get the above message and no matter the yes/no selection the settings won't be imported (because they are only loaded if the ChurchName is the same). As for #807, I think that we should allow importing settings files with different ChurchNames, after user confirmation of course.

I can make a PR for both the issues.

[oleg68]

@larspalo In my case the church name remains the same, but there are another changes in ODF, for example, Pipe999Gain or Pipe999PitchTuning.

The messages you suggested won't be clear in this case.

[larspalo]

In my case the church name remains the same, but there are another changes in ODF, for example, Pipe999Gain or Pipe999PitchTuning.

For such changes the current .cmb import won't work, unless it's a completely "new" stop/rank you're adding. If you as in your case modify an already existing stop, you would need to have the ability to import selectively from .cmb. However, I hope that in the future sampleset creators (and users that modify odfs) won't place such things in the ODF anymore - I for one sure as hell won't! (the main reason for me is that there are already default values that makes it un-necessary to write such things at all, and all the default adaptations I want to make will be shipped with a bundled .cmb instead that's so much nicer to work with)

The messages you suggested won't be clear in this case.

In case you didn't know already - you won't get the log message if the ChurchName is the same! You will however get the message box you mentioned at start of this issue. I plan to change that message partly according to your suggestion, but since it's not necessarily only combinations that are imported I think that the message box text could be: The .cmb file does not exactly match the current ODF. Importing it can cause various problems. Should it really be imported? What do you think about that?

[oleg68]

For such changes the current .cmb import won't work

I import Combinations, not Organ Settings. And now it works exept the extra error message.

[larspalo]

I import Combinations, not Organ Settings. And now it works exept the extra error message.

It's done the same way anyway in GO... It's just that the settings in the .cmb should be ignored if you only import the combinations. And then no reading of any PitchTuning lines will be done from the .cmb either of course. And you should not have any error message, right? It's only a message box asking for a confirmation of the import, right?

[oleg68]

@larspalo Please don't make a message box, because it requires an extra click. A warning in the message log is enough.

[larspalo]

No, ok. You're right, there's a different LoadCombination! It basically behaves the same though in the background. I'll make a separate PR for this then!

[larspalo]

Right, so for only combination import, you think it's ok with the current limitation of needing same ChurchName?

[larspalo]

And you just want a log message with the text you mentioned above?

[oleg68]

And you just want a log message with the text you mentioned above?

Yes, I do.

[larspalo]

Ok, coming soon!

[oleg68]

Right, so for only combination import, you think it's ok with the current limitation of needing same ChurchName?

I do not like limitations at all. If you make the same message box with changing ChurchName as for importing organ settings it will be perfect.

[larspalo]

Ok, I'll change that too then!