Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatic formatting the code #918

Closed
oleg68 opened this issue Dec 27, 2021 · 0 comments · Fixed by #946
Closed

Automatic formatting the code #918

oleg68 opened this issue Dec 27, 2021 · 0 comments · Fixed by #946
Assignees
@rousseldenis
Milestone
3.6.0

Comments

@oleg68
Copy link
Contributor

oleg68 commented Dec 27, 2021 •
edited
Loading

Provide a way for automatic formatting the GrandOrgue source code.

There are several variants:

  • Some tool (ex. git clang-format) to run manually before commit
  • A test in the Github workflow that checks that all code is formatted correctly
  • Some Github push hook
  • anything else

The formatting rules are discussed at #920
@oleg68 oleg68 mentioned this issue Dec 27, 2021
Merged
@rousseldenis rousseldenis mentioned this issue Jan 6, 2022
Merged
@oleg68 oleg68 added this to the 3.5.1 milestone Jan 6, 2022
@oleg68 oleg68 linked a pull request Jan 9, 2022 that will close this issue
[IMP] pre-commit: Use formatting #946
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rousseldenis rousseldenis

Labels
None yet
Projects
None yet
Milestone
3.6.0
Development

Successfully merging a pull request may close this issue.

[IMP] pre-commit: Use formatting rousseldenis/grandorgue
2 participants
@oleg68 @rousseldenis